Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing python includes for Unix hosts #809

Merged
merged 3 commits into from
Aug 27, 2022
Merged

Fix missing python includes for Unix hosts #809

merged 3 commits into from
Aug 27, 2022

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Aug 27, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

This PR fixes the current breakage on some platforms when building packages from sdist artifacts.

This change is an extension of #803 but applies part of the change to MacOS hosts to Linux hosts as well.

Issue Number:

What is the new behavior?

Adds the correct import path to be able to find Python.h

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre changed the title Add missing python includes for unix hosts Fix missing python includes for Unix hosts Aug 27, 2022
@UebelAndre UebelAndre marked this pull request as ready for review August 27, 2022 15:59
@UebelAndre UebelAndre mentioned this pull request Aug 27, 2022
Merged
groodt
groodt approved these changes Aug 27, 2022
View reviewed changes
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/pip_install/pip_repository.bzl Outdated Show resolved Hide resolved
@groodt groodt merged commit dd2e947 into bazelbuild:main Aug 27, 2022
@groodt groodt mentioned this pull request Aug 27, 2022
Closed
5 tasks
@UebelAndre UebelAndre deleted the cppflags branch August 27, 2022 21:27
@mvgijssel mvgijssel mentioned this pull request Aug 29, 2022
Closed
@garymm garymm mentioned this pull request Aug 29, 2022
Closed
ianpegg-bc pushed a commit to ianpegg-bc/rules_python that referenced this pull request May 12, 2023
@UebelAndre @groodt @ianpegg-bc
Fix missing python includes for Unix hosts (bazelbuild#809)
443bfab 
* Fix missing python includes for Unix hosts

* Update python/pip_install/pip_repository.bzl

Co-authored-by: Greg Roodt <groodt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt groodt approved these changes

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UebelAndre @groodt