Cherry-pick: Introduce a pure Swift runfiles library (#1310) #1496
+979
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
luispadron
changed the title
luispadron
force-pushed
the
luis/cherry-pick-swift-runfiles
branch
2 times, most recently
from
25ac7f2 to
6c77ff9
Compare
aaronsky
approved these changes
Mar 11, 2025
Fixes #890 I followed guidance from @fmeum and based this implementation on the runfiles library of `rules_python` where applicable since this was pointed as the reference implementation. In addition to `rules_python` implementation, this implementation uses a similar mechanism as the C++ implementation for deducing the `RUNFILES_DIR` and `RUNFILES_MANIFEST_FILE` location based on `argv0`. --------- Co-authored-by: Brentley Jones <github@brentleyjones.com> Co-authored-by: Luis Padron <heyluispadron@gmail.com> Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
luispadron
force-pushed
the
luis/cherry-pick-swift-runfiles
branch
from
6c77ff9 to
f794034
Compare
|
@brentleyjones 🙏🏼, Aaron doesnt seem to have review rights to this branch |
brentleyjones
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #1310 into 2.x branch.