Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libgconf #2819

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Add libgconf #2819

merged 4 commits into from
Jul 30, 2019

Conversation

alex-magana
Copy link
Contributor

@alex-magana alex-magana commented Jul 30, 2019 •
edited
Loading

Resolves #NUMBER

Fix

/home/travis/.cache/Cypress/3.4.1/Cypress/Cypress: error while loading shared libraries: libgconf-2.so.4: cannot open shared object file: No such file or directory

Code changes:

  • Add the libgconf package which isn't available by default in Ubuntu 16
before_install:
  - sudo apt-get install -y libgconf-2-4

Reference

cypress-io/cypress#1526
cypress-io/cypress#4807
cypress-io/cypress#4069 (comment)

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@alex-magana alex-magana self-assigned this Jul 30, 2019
@alex-magana alex-magana marked this pull request as ready for review July 30, 2019 15:33
@alex-magana alex-magana added this to the Simorgh 2.0 milestone Jul 30, 2019
DemonusPC
DemonusPC approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@DemonusPC DemonusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dank

@alex-magana alex-magana merged commit c628aa7 into latest Jul 30, 2019
@alex-magana alex-magana deleted the fix-missing-libgconf branch July 30, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekp thekp thekp approved these changes

@dr3 dr3 dr3 approved these changes

@jamesdonoh jamesdonoh jamesdonoh approved these changes

@DemonusPC DemonusPC DemonusPC approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@chris-hinds chris-hinds Awaiting requested review from chris-hinds

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@alex-magana alex-magana

Labels
None yet
Projects
None yet
Milestone
Simorgh 2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@alex-magana @DemonusPC @jamesdonoh @dr3 @thekp