-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile under esp-idf new build sysytem #1562
Conversation
Hi @qt1, Thank you very much for this PR 👍 Can you confirm that you tested the patch and that it works as expected? Best regards, |
Hi, I can confirm that the errors from the build system are resolved. I did not test the code itself as there are other, unrelated, errors to the build. Unfortunately I am not familiar with CI. Maybe @projectgus , who actually resolved this issue, can help. |
I'll wait until you can confirm that this patch is fully functional, useful, and necessary. Moreover, I don't understand the motivation since ArduinoJson already implements good practices for CMake (as far as I know), supporting |
@bblanchon Functionality: It works locally, and we will soon see it working with the new ci pipeline step added. Usefullness & Necessary: Well, I would like to see this functionality added. It is the way of handling ESP32 + Arduino projects with proper Cmake (i.e. without platformio or arduino IDE), which in my opinion is a lot nicer. I would use this functionality in here: https://github.com/andreaskuster/ESP32-WebCam in conjunction with the ESPAsyncWebServer. About the motivation of using this extra build structure instead of the standard CMake find_library functionality: I totally agree with you that I do not understand why they cannot use the standard |
This is a non intrusive addition to CMmakeLists.txt that enables using as esp-idf component with the new build system.
For more details please see:
espressif/esp-idf#7024