Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci pipeline to PR: Compile under esp-idf new build sytem #1599

Closed
wants to merge 10 commits into from

Conversation

andreaskuster
Copy link
Contributor

I extended your PR #1562 with the continuous integration pipeline functionality.

There are a few other PRs open to make this working (namely, the Ethernet library has to be ported as well):

Add esp-idf cmake build system component registration arduino-libraries/Ethernet#164
After this has been resolved, we can continue in the merge process of the actual PR to ArduinoJson

@andreaskuster
Copy link
Contributor Author

@bblanchon: See #1562 (comment)

@bblanchon
Copy link
Owner

Hi @andreaskuster,

Thank you very much for this PR ❤️

Supposing that the build passes, I'll make a few changes to make it more consistent with the other jobs.
Please don't feel offended if I modify your code: it's not a judgment about the PR; it's just me being pedantic.

Best regards,
Benoit

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.044% when pulling d918b43 on andreaskuster:master into a6fc931 on bblanchon:6.x.

@andreaskuster
Copy link
Contributor Author

@bblanchon Sure, not problem. I am glad to help :)

It seems as if the ci pipeline passed (except some unrelated package download in GCC for ARM processor

Let me know if you need any help or explanation.

@andreaskuster andreaskuster changed the title WIP: Add ci pipeline to PR: Compile under esp-idf new build sytem Add ci pipeline to PR: Compile under esp-idf new build sytem Jun 27, 2021
@andreaskuster andreaskuster marked this pull request as ready for review June 27, 2021 22:28
bblanchon pushed a commit that referenced this pull request Jun 28, 2021
@bblanchon bblanchon added this to the v6.18.1 milestone Jun 30, 2021
@bblanchon bblanchon closed this in 52e856f Jun 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants