Ignore parse exceptions #1066
Merged
Ignore parse exceptions #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Ruby head test fails due to igrigorik/em-http-request#365. |
bquorning
approved these changes
Aug 28, 2024
|
Thank you @c960657 ! I appreciate the explanation and the PR. I agree it makes sense to ignore the parsing exceptions and simply not match the request body. Any suggestions on how to fix the em-http-client issue in Ruby head, or just wait for em-http-client to be fixed? |
|
Hmm, no, I don't think there is anything WebMock can do about the em-http-client issue. |
|
It is annoying that webmock build fails due to a problem with just one of http clients. |
|
We can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently failing in
masterdue to a change in the latest version of REXML.REXML previously accepted some invalid XML (e.g.
foo bar) but raised on other (<foo bar). Since v3.3.3 it also raises onfoo bar(see ruby/rexml#184).Likewise,
WebMock::Util::JSON.parseaccepts some invalid JSON (e.g.foo bar) but raises on other (e.g.[foo bar).It seems both matchers should just rescue and ignore parse exceptions.