-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude em-http-request on Ruby 3.4 #1070
Conversation
@c960657 Thanks for this PR! I believe the However, I'm not sure the JRuby case should use |
Ok, I reversed that part. |
@@ -3,7 +3,6 @@ | |||
unless RUBY_PLATFORM =~ /java/ | |||
require 'curb' | |||
require 'patron' | |||
require 'em-http' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c960657 why is it important to remove that require
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Ruby HEAD, even require
'ing the library will raise because of the missing constant. Removing it here doesn't seem to affect the tests on the other Ruby versions AFAICT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c960657 thank you for investigating that and explaining 👍
The current version of em-http-request (1.1.7) is not compatible with Ruby HEAD (see igrigorik/em-http-request#365).
Skip tests for the em-http-request integration on Ruby 3.4 for now in order to allow the other tests to complete.
Best reviewed with “ignore white-space”.