Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-6738 : Allow Contractor to Create Files #3407

Merged
merged 3 commits into from
Aug 14, 2023

- switch exception to a custom one

1f3658e
Select commit
Loading
Failed to load commit list.
Merged

PSP-6738 : Allow Contractor to Create Files #3407

- switch exception to a custom one
1f3658e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 14, 2023 in 0s

72.15% (target 75.00%)

View this Pull Request on Codecov

72.15% (target 75.00%)

Details

Codecov Report

Merging #3407 (1f3658e) into dev (39b2447) will decrease coverage by 0.05%.
The diff coverage is 48.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3407      +/-   ##
==========================================
- Coverage   72.20%   72.15%   -0.05%     
==========================================
  Files        1324     1326       +2     
  Lines       30813    30842      +29     
  Branches     5740     5744       +4     
==========================================
+ Hits        22247    22254       +7     
- Misses       8328     8348      +20     
- Partials      238      240       +2     
Files Changed Coverage Δ
...quisition/Controllers/AcquisitionFileController.cs 69.87% <ø> (ø)
.../api/Helpers/Middleware/ErrorHandlingMiddleware.cs 0.00% <ø> (ø)
...nd/core/Exceptions/ContractorNotInTeamException.cs 25.00% <25.00%> (ø)
...pi/Helpers/Extensions/AcquisitionFileExtensions.cs 50.00% <50.00%> (ø)
...quisition/hooks/useAddAcquisitionFormManagement.ts 86.95% <70.00%> (-13.05%) ⬇️
...rce/backend/api/Services/AcquisitionFileService.cs 73.20% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes