SPIKE: Siteminder Refresh #3720
Conversation
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
siteminder
branch
from
416391a
to
75b12fd
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
siteminder
branch
from
13cf90f
to
9dd5f4a
Compare
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.1 #3720 +/- ##
==========================================
- Coverage 74.91% 73.90% -1.01%
==========================================
Files 1439 950 -489
Lines 37184 20388 -16796
Branches 6973 5873 -1100
==========================================
- Hits 27855 15067 -12788
+ Misses 9051 5321 -3730
+ Partials 278 0 -278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
devinleighsmith
force-pushed
the
siteminder
branch
from
9dd5f4a
to
4ffcf8a
Compare
|
✅ No secrets were detected in the code. |
|
Converting back to draft, this should not be merged until 5.1 |
| axios.get(parcelsLayerUrl + siteminderRefreshUrl); | ||
| }, [parcelsLayerUrl, siteminderRefreshUrl]); | ||
|
|
||
| return useMemo( |
There was a problem hiding this comment.
this looks kind odd, but should it be a state rather than a computed variable that only depends on itself for updating?
There was a problem hiding this comment.
uh, yeah, this is from a pattern I use where multiple functions are being returned from a hook. Not necessary in this case.
devinleighsmith
force-pushed
the
siteminder
branch
from
4ffcf8a
to
3a60b49
Compare
POC possible implementation of siteminder token refresh.