psp-7630 ensure that properties added directly to inventory have the … #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
asanchezr
reviewed
Jan 18, 2024
| @@ -947,7 +947,7 @@ public void UpdateProperties_MatchProperties_NewProperty_Success() | |||
| coordinateService.Setup(x => x.TransformCoordinates(It.IsAny<int>(), It.IsAny<int>(), It.IsAny<Coordinate>())).Returns(new Coordinate(924046.3314288399, 1088892.9140135897)); | |||
|
|
|||
| var propertyService = this._helper.GetService<Mock<IPropertyService>>(); | |||
| propertyService.Setup(x => x.PopulateNewProperty(It.IsAny<PimsProperty>())).Returns(new PimsProperty() | |||
| propertyService.Setup(x => x.PopulateNewProperty(It.IsAny<PimsProperty>(), It.IsAny<Boolean>())).Returns(new PimsProperty() | |||
There was a problem hiding this comment.
please fix this compilation error
asanchezr
approved these changes
Jan 18, 2024
|
✅ No secrets were detected in the code. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #3728 +/- ##
==========================================
+ Coverage 74.91% 76.34% +1.43%
==========================================
Files 1440 492 -948
Lines 37187 16787 -20400
Branches 6975 1105 -5870
==========================================
- Hits 27858 12816 -15042
+ Misses 9051 3693 -5358
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…correct flags set.
Signed-off-by: devinleighsmith <devinleighsmith@gmail.com>
devinleighsmith
force-pushed
the
psp-7630
branch
from
d27123c
to
a181dd4
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
added a commit
that referenced
this pull request
Feb 1, 2024
* Refactoring of modals and changes on Smoke Test Automation Test Cases * Automation refactoring - modals, updating fields on Compensation, Digital Docs for Property Management * Refactoring modals * Automation refactoring - modals, updating fields on Compensation, Digital Docs for Property Management * Refactoring modals * Automation updates * Automation updates * Contacts elements update * Digital Documents subtitles fix * CI: Bump version to v5.0.0-71.25 * Version bump (#3729) * CI: Bump version to v5.0.0-72.1 * Disposition Files initial Automation * CI: Bump version to v5.0.0-72.2 * Psp 7611 - ensure undefined/null handled correctly by contact parsers. (#3730) * handle null and undefined contact fields. * remove debugger; * CI: Bump version to v5.0.0-72.3 * PSP-7578 Remove Project and Product from Header of Disposition File (#3734) * Fix runtime error when user guid is invalid * Remove Project and Product from Header of Disposition File * Test corrections * CI: Bump version to v5.0.0-72.4 * psp-7630 ensure that properties added directly to inventory have the … (#3728) * psp-7630 ensure that properties added directly to inventory have the correct flags set. * test correction. Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> --------- Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> * CI: Bump version to v5.0.0-72.5 * psp-7609 ensure that changing the status of an acq file generates a note. (#3726) * CI: Bump version to v5.0.0-72.6 * lint correction. (#3733) * CI: Bump version to v5.0.0-72.7 * IS-72.00 Database Schema (#3716) * IS-72.00 Database Schema PSP_PIMS S72.00 Sprint 72 2024-Jan-16 - Altered tables: - PIMS_PROPERTY - PIMS_PROPERTY_HIST - Altered build scripts: - 002_PSP_PIMS_Build.sql - 020_DML_PIMS_STATIC_VARIABLE.sql - 148_DML_PIMS_DSP_CHKLST_ITEM_TYPE.sql - Added test scripts: - 071_PIMS_PROPERTY_CONTACT.sql - Altered test scripts: - 005_DML_LEASE_PROPERTY.sql - Requires additional metadata to meet standards * fixed build not matching alter up result * aligned latest folder --------- Co-authored-by: Manuel Rodriguez <marobej@gmail.com> * CI: Bump version to v5.0.0-72.8 * generated scaffold and removed lingering files (#3738) * CI: Bump version to v5.0.0-72.9 * Disposition checklist automation * fixed the disposition bug 7582 * CI: Bump version to v5.0.0-72.10 * Added Reordering of the DISPLAY_ORDER Columns (#3742) Reordered the display order following the insertion/deletion of the PIMS_DSP_CHKLST_ITEM_TYPE table. * CI: Bump version to v5.0.0-72.11 * PSP-7296 : Create/Edit Sales Details (Disposition) (#3731) * CI: Bump version to v5.0.0-72.12 * PSP-7639 PIMS HIST Table fix commit (#3743) Fix on missing Historical rows that were identified on 3 tables in UAT database 1.PIMS_INSURANCE 2.PIMS_LEASE_TENANT 3.PIMS_PROPERTY_LEASE * CI: Bump version to v5.0.0-72.13 * PSP-7509 : Allow Contractor to Create or Edit Disposition File (#3735) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v5.0.0-72.14 * Disposition File details, documents and notes. Refactoring on File Properties * PSP-7510 : Disallow Contractor to Remove Themself from Disposition File (#3745) Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com> * CI: Bump version to v5.0.0-72.15 * correct disposition list view file number. (#3736) * CI: Bump version to v5.0.0-72.16 * Offers and sales tab automation * disposition offers and sales tab * Psp 7614, 7657, 7626, 7610 assorted text corrections. (#3737) * text corrections. * correct title text. * psp-7657 fix modal buttons. * test updates. * lint fixes. * CI: Bump version to v5.0.0-72.17 * CI: Bump version to v5.0.0-72.18 * Refactoring and Disposition file automation * Merge conflicts between local and remote * Disposition files - Offers and sale create and update * Deleting AcquisitionProperties class, replaced by SharedFileProperties * Text changes (#3752) * CI: Bump version to v5.0.0-72.19 * correct message text. (#3749) * CI: Bump version to v5.0.0-72.20 * Refactoring LeaseTenants class * CI: Bump version to v5.0.0-72.21 * PSP-6668 FT: Acquisition File: Compensation: Show error modal instead of toast when total allowable compensation value is less than total compensation value (#3755) * Show modal popup with warning message for total allowable compensation * Test corrections * CI: Bump version to v5.0.0-72.22 * PSP-7664 FT-REG: When cancelling, the confirmation modal should be consistent around different types of files (#3747) * Increase the default width of modals * Rename file * Refactor duplicate code * Verbiage update * Update snapshots * Text updates * Test corrections * CI: Bump version to v5.0.0-72.23 * psp-7680 add agreement status type to agreement export. (#3751) * add agreement status type to agreement export. * test corrections. * CI: Bump version to v5.0.0-72.24 * Pipeline updates (#3756) * add keycloak sync to all pipelines. add uat hotfix and pre-release hotfix pipelines. update builds/keycloak sync to support new configuration. * correct uat secret name * add prod secrets for keycloak sync * correct typo. * CI: Bump version to v5.0.0-72.25 --------- Signed-off-by: devinleighsmith <devinleighsmith@gmail.com> Co-authored-by: Sue Tairaku <sue.tairaku@gmail.com> Co-authored-by: Sue Tairaku <42981334+stairaku@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: praveen <praveen.porumalla@quartech.com> Co-authored-by: devinleighsmith <41091511+devinleighsmith@users.noreply.github.com> Co-authored-by: Doug Filteau <dfilteau@users.noreply.github.com> Co-authored-by: Manuel Rodriguez <marobej@gmail.com> Co-authored-by: pravkuma14 <133119915+pravkuma14@users.noreply.github.com> Co-authored-by: Eduardo <eddherrera@users.noreply.github.com> Co-authored-by: ap-quartech <146900628+ap-quartech@users.noreply.github.com> Co-authored-by: Eduardo Herrera <Eduardo.Herrera@quartech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…correct flags set.