psp-8783 ensure that form state is maintained during collapsing of sidebar. #4168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-8783
branch
from
d4f8af9
to
b0c4043
Compare
|
✅ No secrets were detected in the code. |
| toggleExpanded={toggleSidebarDisplay} | ||
| /> | ||
| </span> | ||
| <StyledSidebarWrapper className={mapSideBarViewState.isCollapsed ? '' : 'expanded'}> |
There was a problem hiding this comment.
nit: this could also be passed as a parameter to the styled component
There was a problem hiding this comment.
The other subtle change here is that we removed the VisibilitySensor (which we mock in a lot of unit tests). Given that we don't use it anymore we should update the tests to remove the unnecessary mocking.
Not required for this PR - should be a tech-debt task. Just calling out the change
FuriousLlama
approved these changes
Jul 15, 2024
|
✅ No secrets were detected in the code. |
|
@devinleighsmith please update the snapshots to resolve conflicts |
asanchezr
approved these changes
Jul 15, 2024
devinleighsmith
force-pushed
the
psp-8783
branch
from
e5b41fd
to
24930d9
Compare
Signed-off-by: devinleighsmith <devinleighsmith@gmail.com>
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
This was referenced Aug 19, 2024
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.