PSP-7158 Allow moving the position of map markers (within the file) #4233
Conversation
|
✅ No secrets were detected in the code. |
2 similar comments
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
| repositioningFeatureDataset: LocationFeatureDataset | null, | ||
| index: number | null, |
There was a problem hiding this comment.
Can these be null if they are necessary for the state?
There was a problem hiding this comment.
good catch - will change
| actions: [ | ||
| assign({ | ||
| repositioningFeatureDataset: () => null, | ||
| repositioningPropertyIndex: () => null, |
There was a problem hiding this comment.
does selectingComponentId need to be set to null as well?
| @@ -206,7 +219,7 @@ const MapLeafletView: React.FC<React.PropsWithChildren<MapLeafletViewProps>> = ( | |||
| ))} | |||
| </LayerGroup> | |||
| )} | |||
| {mapMachine.showPopup && ( | |||
| {mapMachine.showPopup && !mapMachine.isRepositioning && ( | |||
There was a problem hiding this comment.
this is kinda odd. The mapMachine should be the sole authority in deciding if the popup should be shown. Otherwise, we risk having the logic distributed. Would it be possible to have the state so both showPopup and isRepositioning can never happen together?
asanchezr
force-pushed
the
psp-7158-move-file-markers
branch
from
5b7e596
to
f705f7e
Compare
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
video.mp4