psp-9080 add missing LEASE_STAKEHOLDER_TYPE codes. #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
devinleighsmith
commented
Aug 26, 2024
| @@ -100,10 +100,12 @@ export const Select: React.FC<React.PropsWithChildren<SelectProps>> = ({ | |||
| }; | |||
|
|
|||
| const renderPlaceholder = () => { | |||
| if (!placeholder) { | |||
| const calculatedPlaceholder = | |||
| !value || options.find(option => option.value === value) ? null : 'N/A'; // Render N/A in the event that the currently selected value is not in the list. | |||
There was a problem hiding this comment.
Note: this is required, otherwise if a value is currently selected that is not in the options list, the select will default to showing the first value in the options list, even if that is not what the select's current value is. To correct this, the user would have to select the value which currently appears selected, which is not intuitive.
devinleighsmith
commented
Aug 26, 2024
| @@ -0,0 +1,53 @@ | |||
| IF NOT EXISTS ( | |||
There was a problem hiding this comment.
It looks like Doug did a migration of the old values in the alter up, but forgot to add these new values. They are present in the BUILD.
eddherrera
approved these changes
Aug 26, 2024
asanchezr
approved these changes
Aug 26, 2024
devinleighsmith
force-pushed
the
psp-9080
branch
from
3920487
to
9449008
Compare
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.