add detail comment (part 2) #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
force-pushed
the
2719
branch
2 times, most recently
from
b2b285e
to
07935ca
Compare
severinbeauvais
force-pushed
the
2719
branch
from
7082bce
to
9fe1e0d
Compare
severinbeauvais
requested review from
cameron-eyds,
katiemcgoff and
rarmitag
cameron-eyds
approved these changes
Feb 20, 2020
thorwolpert
reviewed
Feb 24, 2020
- added Add Comment Dialog unit tests - added Detail Comment unit tests - refactored Directors unit tests to not use setTimeout() - fixed filing save tests (missing 'get tasks') - cleaned up other unit tests - added Detail Comment autofocus prop - display app version on startup to console - removed obsolete hard-coded entity type (code still not in use) - ensures comments are sorted by timestamp
severinbeauvais
force-pushed
the
2719
branch
from
ee8ed51
to
0d3d073
Compare
|
SonarCloud Quality Gate failed.
|
thorwolpert
approved these changes
Feb 24, 2020
thorwolpert
pushed a commit
to thorwolpert/business-filings-ui
that referenced
this pull request
Mar 16, 2020
* oracledb not starting Signed-off-by: Kial Jinnah <kialj876@gmail.com> * working dockerfile Signed-off-by: Kial Jinnah <kialj876@gmail.com> * oracle running in openshift Signed-off-by: Kial Jinnah <kialj876@gmail.com> * cleaned up dockerfile/echo stmnts Signed-off-by: Kial Jinnah <kialj876@gmail.com> * deployment config added Signed-off-by: Kial Jinnah <kialj876@gmail.com> * readme for oracle container Signed-off-by: Kial Jinnah <kialj876@gmail.com>
severinbeauvais
pushed a commit
to severinbeauvais/business-filings-ui
that referenced
this pull request
Mar 19, 2021
completed files for build/deploy from GH Actions
severinbeauvais
pushed a commit
to severinbeauvais/business-filings-ui
that referenced
this pull request
Mar 19, 2021
* initial commit * Updated for initial PR * Removed padding class * Pr Comments Update * Initial Commit. Form Implementation * Wrap up NameRequest UI correction * import clean up * Console clean up * Pr Updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#2719
Description of changes:
display app version on startup to consoledeletedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).