Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Add Detail Comment (Part 2) #2719

Closed
6 of 13 tasks
severinbeauvais opened this issue Feb 15, 2020 · 2 comments
Closed
6 of 13 tasks

UI - Add Detail Comment (Part 2) #2719

severinbeauvais opened this issue Feb 15, 2020 · 2 comments
Assignees
Labels
ENTITY Business Team

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Feb 15, 2020

Description:

This ticket exists to:

Acceptance for a Task:

  • Requires deployments
  • Add/ maintain selectors for QA purposes
  • Test coverage acceptable
  • Linters passed
  • Peer Reviewed
  • PR Accepted
  • Production burn in completed
@severinbeauvais severinbeauvais added the ENTITY Business Team label Feb 15, 2020
@severinbeauvais severinbeauvais changed the title COOP-UI: finish Detail Comments (unit tests, etc) COOP-UI: finish Add Detail Comment (unit tests, etc) Feb 15, 2020
@severinbeauvais severinbeauvais changed the title COOP-UI: finish Add Detail Comment (unit tests, etc) COOP-UI: Add Detail Comment (Part 2) Feb 15, 2020
@severinbeauvais severinbeauvais changed the title COOP-UI: Add Detail Comment (Part 2) UI - Add Detail Comment (Part 2) Feb 15, 2020
@severinbeauvais severinbeauvais self-assigned this Feb 18, 2020
@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Feb 20, 2020

Testing Notes

Although this task mostly updated the unit tests, a few collateral things were fixed too. So please verify:

  • detail comments are now explicitly sorted newest to oldest (the API previously returned them this way but it's not guaranteed due to possible inline caching -- anyway it will be hard to tell a difference but order should be correct no matter what)
  • when adding a detail comment, the textarea should initially have focus (so you can just start typing, no need to click into it first)
  • when saving a detail comment, just the comments for the subject filing should be updated; the whole dashboard is not reloaded
  • the app name and version is now displayed in the dev console when the app starts see UIs should display their version number #2555
  • resuming a draft AR was touched but should still work
  • resuming a draft COD was touched but should still work
  • resuming a draft COA was touched but should still work

@JohnamLane
Copy link
Collaborator

Verified in DEV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

2 participants