5530 legal name change related schema updates #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argush3
force-pushed
the
dev_legal_name_changes
branch
2 times, most recently
from
9e95753
to
cd9597f
Compare
argush3
force-pushed
the
dev_legal_name_changes
branch
from
cd9597f
to
d0aa022
Compare
argush3
commented
Aug 3, 2023
| @@ -1,4 +1,4 @@ | |||
| flask | |||
| jsonschema[format] | |||
| jsonschema[format]==4.17.3 | |||
There was a problem hiding this comment.
Pinned down jsonschema version to 4.17.3 as tests fail otherwise. 4.18.0 actually passes tests but fails linter so needed to use 4.17.3
vysakh-menon-aot
approved these changes
Aug 3, 2023
JazzarKarim
pushed a commit
to JazzarKarim/business-schemas
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#5530
Note: this will be merged into a feature branch for legal name changes to isolate legal name specific changes from main branch.
Description of changes:
businessNamefield to business schema. This will make it easier for FE & API consumers to just reference one field to retrieve the name the business is using to do business. For firms, this will be the operating name and for other business types this is the legal name.businessNameto business block of various schema example data templatesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).