Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5530 legal name change related schema updates #140

Merged
merged 1 commit into from
Aug 3, 2023
Merged

5530 legal name change related schema updates #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
flask
jsonschema[format]
jsonschema[format]==4.17.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned down jsonschema version to 4.17.3 as tests fail otherwise. 4.18.0 actually passes tests but fails linter so needed to use 4.17.3

requests
strict-rfc3339
20 changes: 20 additions & 0 deletions src/registry_schemas/example_data/schema_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-04-15T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
}
}
Expand All @@ -49,6 +50,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-04-15T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP',
'state': 'ACTIVE',
'goodStanding': True,
Expand All @@ -70,6 +72,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-04-15T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP',
'state': 'HISTORICAL',
'stateFiling': 'https://LEGAL-API-HOST/api/v2/businesses/IDENTIFIER/filings/FILING_ID'
Expand Down Expand Up @@ -101,6 +104,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
},
'annualReport': {
Expand Down Expand Up @@ -374,6 +378,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
},
'correction': {
Expand Down Expand Up @@ -464,6 +469,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
},
'correction': {
Expand Down Expand Up @@ -518,6 +524,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
},
'correction': {
Expand Down Expand Up @@ -630,6 +637,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
},
'correction': {
Expand Down Expand Up @@ -1057,6 +1065,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - BC1234567',
'businessName': 'legal name - BC1234567',
'legalType': 'BC'
},
'correction': {
Expand Down Expand Up @@ -1488,6 +1497,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - FM1234567',
'businessName': 'legal name - FM1234567',
'legalType': 'GP'
},
'correction': {
Expand Down Expand Up @@ -1693,6 +1703,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - FM1234567',
'businessName': 'legal name - FM1234567',
'legalType': 'GP'
},
'correction': {
Expand Down Expand Up @@ -2363,6 +2374,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-04-15T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
}
}
Expand Down Expand Up @@ -2413,6 +2425,7 @@
'foundingDate': '2018-01-01T00:00:00+00:00',
'identifier': 'U1234567',
'legalName': 'legal name - Test',
'businessName': 'legal name - Test',
'legalType': 'BC'
},
'alteration': ALTERATION
Expand All @@ -2433,6 +2446,7 @@
'identifier': 'BC1234567',
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'legalName': 'legal name - BC1234567',
'businessName': 'legal name - BC1234567',
'legalType': 'BC'
},
'conversion': BEN_CONVERSION
Expand All @@ -2454,6 +2468,7 @@
'identifier': 'BC1234567',
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'legalName': 'legal name - BC1234567',
'businessName': 'legal name - BC1234567',
'legalType': 'BC'
},
'transition': TRANSITION
Expand All @@ -2473,6 +2488,7 @@
'foundingDate': '2018-01-01T00:00:00+00:00',
'identifier': 'U1234567',
'legalName': 'legal name - Test',
'businessName': 'legal name - Test',
'legalType': 'BC'
},
'registrarsNotation': REGISTRARS_NOTATION
Expand All @@ -2492,6 +2508,7 @@
'foundingDate': '2018-01-01T00:00:00+00:00',
'identifier': 'U1234567',
'legalName': 'legal name - Test',
'businessName': 'legal name - Test',
'legalType': 'BC'
},
'registrarsOrder': REGISTRARS_ORDER
Expand All @@ -2511,6 +2528,7 @@
'foundingDate': '2018-01-01T00:00:00+00:00',
'identifier': 'U1234567',
'legalName': 'legal name - Test',
'businessName': 'legal name - Test',
'legalType': 'BC'
},
'courtOrder': COURT_ORDER
Expand All @@ -2530,6 +2548,7 @@
'foundingDate': '2018-01-01T00:00:00+00:00',
'identifier': 'FM1234567',
'legalName': 'legal name - Test',
'businessName': 'legal name - Test',
'legalType': 'GP'
},
'changeOfRegistration': CHANGE_OF_REGISTRATION
Expand All @@ -2555,6 +2574,7 @@
'lastLedgerTimestamp': '2019-04-15T20:05:49.068272+00:00',
'lastPreBobFilingTimestamp': '2019-01-01T20:05:49.068272+00:00',
'legalName': 'legal name - CP1234567',
'businessName': 'legal name - CP1234567',
'legalType': 'CP'
},
'changeOfName': {
Expand Down
12 changes: 11 additions & 1 deletion src/registry_schemas/schemas/business.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,18 @@
},
"legalName": {
"type": "string",
"title": "The Legal_name Schema",
"title": "The Legal Name of the business.",
"default": "",
"examples": ["legal_name"],
"pattern": "^(.*)$"
},
"businessName": {
"type": "string",
"title": "The business name of the business. For firms, this will be the same as the operating name. For other business legal types, this will likely be the same as the legal name.",
"default": "",
"examples": ["business_name"],
"pattern": "^(.*)$"
},
"legalType": {
"type": "string",
"title": "The Legal Type of the business.",
Expand Down Expand Up @@ -151,6 +158,9 @@
"legalName": {
"$ref": "#/definitions/legalName"
},
"businessName": {
"$ref": "#/definitions/businessName"
},
"legalType": {
"$ref": "#/definitions/legalType"
},
Expand Down
Loading