17941 add agm_location_change_schema #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vysakh-menon-aot
approved these changes
Oct 10, 2023
argush3
reviewed
Oct 10, 2023
argush3
reviewed
Oct 10, 2023
argush3
approved these changes
Oct 10, 2023
thorwolpert
reviewed
Oct 10, 2023
| 'addressCity': 'mailing_address city', | ||
| 'addressCountry': 'CA', | ||
| 'postalCode': 'H0H0H0', | ||
| 'addressRegion': 'ON', |
There was a problem hiding this comment.
Is this allowed to be any country & province/state?
I ask as you example is not in BC
There was a problem hiding this comment.
The addressRegion can't be BC. Vysakh will be adding validation in the legal api for this.
kialj876
reviewed
Oct 11, 2023
kialj876
reviewed
Oct 11, 2023
argush3
reviewed
Oct 11, 2023
argush3
approved these changes
Oct 11, 2023
argush3
approved these changes
Oct 11, 2023
kialj876
approved these changes
Oct 11, 2023
JazzarKarim
pushed a commit
to JazzarKarim/business-schemas
that referenced
this pull request
Jan 31, 2024
* 17941 add agm_location_change_schema * update comments * remove validation * update addressRegion * update description * update test * update sample schema * use address schema * update the required field and test case * reuse address struct * update schema data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#17941
Description of changes:
Add AGM_Location_change Schema
existing deliveryInstructions field in address schema will be used for additionalLocationDetails
required addressRegion validation will be done in the legal api validators to avoid needing to overriding existing address schema validation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-schemas license (Apache 2.0).