generated from bcgov/bcrs-template-ui
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17941 add agm_location_change_schema #145
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a489482
17941 add agm_location_change_schema
kzdev420 c1731bd
update comments
kzdev420 95fabe4
remove validation
kzdev420 9ae6d9d
update addressRegion
kzdev420 749a502
update description
kzdev420 f693299
update test
kzdev420 266c6fc
update sample schema
kzdev420 8fdf885
use address schema
kzdev420 2089ae4
update the required field and test case
kzdev420 8d9f1dc
reuse address struct
kzdev420 58bb455
update schema data
kzdev420 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$id": "https://bcrs.gov.bc.ca/.well_known/schemas/agm_location_change", | ||
"type": "object", | ||
"definitions": {}, | ||
"title": "AGM Location Change Information Schema", | ||
"required": [ | ||
"agmLocationChange" | ||
], | ||
"properties": { | ||
"agmLocationChange": { | ||
"type": "object", | ||
"required": [ | ||
"year", | ||
"newAgmLocation" | ||
], | ||
"properties": { | ||
"year": { | ||
"type": "string", | ||
"description": "Year of the AGM, Must be on or after incorporation year and cannot be future year." | ||
}, | ||
"newAgmLocation": { | ||
kialj876 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/address" | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,80 @@ | ||
# Copyright © 2019 Province of British Columbia | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
"""Test Suite to ensure agm location change schemas are valid.""" | ||
import copy | ||
from registry_schemas import validate | ||
from registry_schemas.example_data import AGM_LOCATION_CHANGE | ||
|
||
|
||
def test_agm_location_change_schema(): | ||
"""Assert that the JSONSchema validator is working.""" | ||
agm_location_change = copy.deepcopy(AGM_LOCATION_CHANGE) | ||
alc_json = {'agmLocationChange': copy.deepcopy(agm_location_change)} | ||
|
||
is_valid, errors = validate(alc_json, 'agm_location_change') | ||
|
||
if errors: | ||
for err in errors: | ||
print(err.message) | ||
print(errors) | ||
|
||
assert is_valid | ||
|
||
|
||
def test_validate_no_agm_year(): | ||
"""Assert that an year node is present in the agm location change.""" | ||
agm_location_change = copy.deepcopy(AGM_LOCATION_CHANGE) | ||
alc_json = {'agmLocationChange': agm_location_change} | ||
del alc_json['agmLocationChange']['year'] | ||
|
||
is_valid, errors = validate(alc_json, 'agm_location_change') | ||
|
||
if errors: | ||
for err in errors: | ||
print(err.message) | ||
print(errors) | ||
|
||
assert not is_valid | ||
|
||
|
||
def test_validate_no_agm_location(): | ||
"""Assert that an newAgmLocation node is present in the agm location change.""" | ||
agm_location_change = copy.deepcopy(AGM_LOCATION_CHANGE) | ||
alc_json = {'agmLocationChange': agm_location_change} | ||
del alc_json['agmLocationChange']['newAgmLocation'] | ||
|
||
is_valid, errors = validate(alc_json, 'agm_location_change') | ||
|
||
if errors: | ||
for err in errors: | ||
print(err.message) | ||
print(errors) | ||
|
||
assert not is_valid | ||
|
||
|
||
def test_validate_no_agm_address(): | ||
"""Assert that an streetAddress node is present in the agm location change.""" | ||
agm_location_change = copy.deepcopy(AGM_LOCATION_CHANGE) | ||
alc_json = {'agmLocationChange': agm_location_change} | ||
del alc_json['agmLocationChange']['newAgmLocation']['streetAddress'] | ||
|
||
is_valid, errors = validate(alc_json, 'agm_location_change') | ||
|
||
if errors: | ||
for err in errors: | ||
print(err.message) | ||
print(errors) | ||
|
||
assert not is_valid |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this allowed to be any country & province/state?
I ask as you example is not in BC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
addressRegion
can't be BC. Vysakh will be adding validation in the legal api for this.