1703 4 hard delete attachments #1835
Conversation
BCerki
force-pushed
the
1703-4-hard-delete-attachments
branch
9 times, most recently
from
7468350
to
1b8a2a2
Compare
BCerki
force-pushed
the
1703-4-hard-delete-attachments
branch
from
56cf511
to
46eb659
Compare
| # - name: Setup tmate session | ||
| # uses: mxschmitt/action-tmate@v3 | ||
| # with: | ||
| # detached: true |
| @@ -13,3 +13,5 @@ cypress.env.json | |||
| app/cypress.env.json | |||
| dev/db/data | |||
| **/.DS_Store | |||
|
|
|||
| gha-creds-*.json | |||
There was a problem hiding this comment.
Do we need to have any files locally related to this rule?
There was a problem hiding this comment.
This is leftover from experimenting with CI, will remove
|
|
||
| cy.fixture("e2e/mock.pdf").as("mockFile"); | ||
| cy.get("input[type=file]").selectFile("@mockFile"); | ||
| cy.wait(30000); |
There was a problem hiding this comment.
I'm pretty sure you have tested this but just as a sanity check, have you tried using any other assertions rather than using wait? or something like this: https://docs.cypress.io/api/commands/selectfile#Custom-fileName-mimeType-and-lastModified
|
|
||
| const handleArchiveAttachment = (attachmentId) => { | ||
| if (isFirstRevision) { | ||
| console.log("in if handlearchiveattachment"); |
| }; | ||
|
|
||
| console.log("connectionid", connectionId); |
| attachment: { file, id }, | ||
| }, | ||
| } = queryResponse; | ||
| console.log("req.body.variables", req.body.variables); |
| // brianna this isn't working since change to the discard mutation--I think this middleware isn't actually transactional. If this doesn't work the next mutation still fires | ||
| console.log("attachmentFormChangeResponse", attachmentFormChangeResponse); |
| drop function cif.discard_project_attachment_form_change; | ||
| create function cif.discard_project_attachment_form_change(form_change_id int) | ||
| returns cif.form_change |
There was a problem hiding this comment.
I am curious, why not use "create or replace function ..." instead of deleting and creating a new one?
There was a problem hiding this comment.
If the return type is different you can't replace, you have to drop and remake
There was a problem hiding this comment.
Woooo, good to know 👍
|
work finished in #1843 |
card: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1703
The card is only about hard deleting attachments in the first revision. I think there may be some other cases in which we'd like to hard delete (e.g., deleting an attachment that was uploaded in the same form change) and made a tech debt ticket to investigate: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1776
Also, hard deleting attachments as part of discarding a project revision was split into another card: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1798
Also also, cypress CI upload and deletion will be another card: https://app.zenhub.com/workspaces/climate-action-secretariat-60ca4121764d710011481ca2/issues/gh/bcgov/cas-cif/1839