Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1703 hard delete attachments feature #1843

Merged
merged 16 commits into from
Sep 8, 2023
Merged

1703 hard delete attachments feature #1843

merged 16 commits into from
Sep 8, 2023

Conversation

BCerki
Copy link
Contributor

@BCerki BCerki commented Aug 8, 2023

No description provided.

@BCerki BCerki force-pushed the 1703-hard-delete-attachments-feature branch 2 times, most recently from a763ff1 to c862343 Compare August 8, 2023 22:39
@BCerki BCerki marked this pull request as ready for review August 9, 2023 15:50
@BCerki BCerki mentioned this pull request Aug 10, 2023
Closed
@BCerki BCerki force-pushed the 1703-hard-delete-attachments-feature branch from c862343 to a626635 Compare August 10, 2023 22:46
@Sepehr-Sobhani Sepehr-Sobhani force-pushed the 1703-hard-delete-attachments-feature branch from a626635 to 1d2a8d4 Compare August 25, 2023 23:35
@BCerki BCerki force-pushed the 1703-hard-delete-attachments-feature branch 2 times, most recently from a626635 to aeada28 Compare August 28, 2023 17:51
@BCerki BCerki force-pushed the 1703-hard-delete-attachments-feature branch from 522794b to 915d458 Compare September 8, 2023 15:00
@BCerki BCerki force-pushed the 1703-hard-delete-attachments-feature branch from 3728def to 23fb3a8 Compare September 8, 2023 15:08
Sepehr-Sobhani
Sepehr-Sobhani requested changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@Sepehr-Sobhani Sepehr-Sobhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤩 Good job! You just need to remove the sneaky yarn-error.log file :)

@BCerki BCerki merged commit 205ea51 into develop Sep 8, 2023
16 checks passed
@BCerki BCerki deleted the 1703-hard-delete-attachments-feature branch September 8, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sepehr-Sobhani Sepehr-Sobhani Sepehr-Sobhani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BCerki @Sepehr-Sobhani