Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corporation : Creating the magic link and send to company email on file #15769

Closed
jennyschan opened this issue Mar 27, 2023 · 18 comments
Closed
Assignees
Labels
Pay Work for Pay Team

Comments

@jennyschan
Copy link

jennyschan commented Mar 27, 2023

Scenario 1 - happy path
GIVEN the user logged in and has selected a corporation they wish to affiliate with
WHEN "send request email" is selected by default and they click 'ADD'
THEN a modal is presented confirming that an email has been sent
AND a magic affiliation link is sent to the company email on file
AND the link contains specific business that user had been selected for affiliation
AND the link contains the specific account to affiliate

Scenario 2 - cancel flow
GIVEN the user logged in and has selected a corporation they wish to affiliate with
WHEN user clicks the Cancel button
THEN it will navigate back to the My business registry dashboard page

UX design page: https://preview.uxpin.com/c0e1953a537febcbb94df1856812c0ea4b52ccb3#/pages/161898947/simulate/sitemap

@jennyschan jennyschan added the Pay Work for Pay Team label Mar 27, 2023
@jennyschan jennyschan changed the title Creating the magic link Creating the magic link and send to company email on file Mar 27, 2023
@jennyschan jennyschan changed the title Creating the magic link and send to company email on file Corporation : Creating the magic link and send to company email on file Mar 27, 2023
@JohnamLane
Copy link
Collaborator

Hey team! Please add your planning poker estimate with Zenhub @AshnaMehta @Jxio @MatthewCai2002 @seeker25

@rodrigo-barraza rodrigo-barraza self-assigned this Jul 21, 2023
@seeker25
Copy link
Collaborator

seeker25 commented Aug 3, 2023

@PCC199 Could you put these under the current sprint? as well as the objectives?

@seeker25
Copy link
Collaborator

seeker25 commented Aug 3, 2023

I usually filter like this:
image.png

Should I just filter on objectives instead?

@seeker25
Copy link
Collaborator

seeker25 commented Aug 8, 2023

From Jia's ticket
UXA comments added in the link here, talked to Travis about the changes last Friday. https://preview.uxpin.com/c0e1953a537febcbb94df1856812c0ea4b52ccb3#/pages/163990960

@seeker25
Copy link
Collaborator

seeker25 commented Aug 9, 2023

Adding Ody to this ticket, he had to make some backend changes to get this going.

@seeker25
Copy link
Collaborator

Handing this one over to Rodrigo - going to focus on the Vite upgrade for Auth-web

@seeker25
Copy link
Collaborator

Moving this one to UX

@seeker25
Copy link
Collaborator

@rodrigo-barraza can @ethantspitt look at this one on the feature branch? https://bcregistry-account-dev--pr-2458-h7p80jhf.web.app

@ethantspitt
Copy link
Collaborator

Seems the affiliation modal options are not showing using the link above

@ethantspitt
Copy link
Collaborator

Finally can see the preview link using https://bcregistry-account-dev--pr-2458-h7p80jhf.web.app

UX notes:
Private Zenhub Image

Private Zenhub Image

Private Zenhub Image

Expected interaction after a magic link is sent:
Private Zenhub Image

@seeker25 @rodrigo-barraza
I couldn't find the above interaction description in this ticket (adding to the table right after request an email), is it something we implemented already?

@seeker25
Copy link
Collaborator

Not too sure - what do you think @rodrigo-barraza ?

@rodrigo-barraza
Copy link
Collaborator

@ethantspitt @seeker25

To summarize:

@seeker25
Copy link
Collaborator

seeker25 commented Aug 31, 2023

Not merged yet -

Top one is a bit out of scope, fairly certain but anyways:

  1. Select should show select now
  2. Button should be fixed
  3. Working on the toast and highlighting now

@ethantspitt
Copy link
Collaborator

ethantspitt commented Sep 1, 2023

Thanks for the update, two minor comments:

  1. after added to the table, there should be no "not in good standing" warning alert
    Private Zenhub Image

  2. Styling comment:
    Private Zenhub Image

@seeker25
Copy link
Collaborator

seeker25 commented Sep 1, 2023

  1. is fixed,
  2. I've made a small change for now - will see if I can fix it in a bit

@seeker25
Copy link
Collaborator

seeker25 commented Sep 5, 2023

  1. still needs to be done:

[Uploading... image.png]

@seeker25
Copy link
Collaborator

seeker25 commented Sep 5, 2023

Private Zenhub Image

@seeker25
Copy link
Collaborator

Closing we can do testing in 17057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pay Work for Pay Team
Projects
None yet
Development

No branches or pull requests

6 participants