Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15769 - Backend changes - for masked email for contacts. #2426

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Aug 8, 2023

Issue #:
bcgov/entity#15769

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

@seeker25 seeker25 self-assigned this Aug 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@seeker25 seeker25 marked this pull request as ready for review August 8, 2023 15:45
@seeker25 seeker25 requested a review from ochiu August 8, 2023 15:49
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2426 (01ec312) into main (261dc17) will increase coverage by 8.98%.
Report is 5 commits behind head on main.
The diff coverage is 88.42%.

@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
+ Coverage   80.71%   89.69%   +8.98%     
==========================================
  Files         322      159     -163     
  Lines       11915     8558    -3357     
  Branches      618        0     -618     
==========================================
- Hits         9617     7676    -1941     
+ Misses       2289      882    -1407     
+ Partials        9        0       -9     
Flag Coverage Δ
accountmailerqueue ?
activityloglistenerqueue ?
authapi 89.69% <88.42%> (-0.27%) ⬇️
authweb ?
eventlistenerqueue ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...i/src/auth_api/resources/affiliation_invitation.py 86.84% <81.81%> (-3.45%) ⬇️
...pi/src/auth_api/services/affiliation_invitation.py 81.22% <84.25%> (-4.55%) ⬇️
...-api/src/auth_api/models/affiliation_invitation.py 91.36% <84.44%> (-6.05%) ⬇️
auth-api/src/auth_api/resources/entity.py 90.06% <90.90%> (-0.08%) ⬇️
auth-api/src/auth_api/services/user.py 93.34% <90.90%> (-0.07%) ⬇️
auth-api/src/auth_api/exceptions/errors.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/models/dataclass.py 100.00% <100.00%> (ø)
auth-api/src/auth_api/models/membership.py 72.41% <100.00%> (ø)
auth-api/src/auth_api/schemas/__init__.py 100.00% <100.00%> (ø)
...api/src/auth_api/schemas/affiliation_invitation.py 100.00% <100.00%> (ø)
... and 5 more

... and 163 files with indirect coverage changes

@seeker25 seeker25 merged commit 7c97e8a into bcgov:main Aug 8, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants