Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15769 - Manage a B.C. Business modal view for Corporation #2468

Merged
merged 49 commits into from
Aug 24, 2023
Merged

15769 - Manage a B.C. Business modal view for Corporation #2468

merged 49 commits into from
Aug 24, 2023

Conversation

rodrigo-barraza
Copy link
Collaborator

Issue #:15769
bcgov/entity#15769

Additions and changes for managing a B.C. business modal for corporations. Visual fixes to related modals, and copy updates.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-auth license (Apache 2.0).

seeker25
seeker25 reviewed Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please nudge package.json and package lock as well - I will be moving it up a minor version when we merge to main though

@Jxio
Copy link
Collaborator

Jxio commented Aug 18, 2023

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2468-ozcq53tu.web.app

@seeker25
Copy link
Collaborator

/gcbrun

@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2468-ozcq53tu.web.app

seeker25
seeker25 requested changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@seeker25 seeker25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some concerns to address before this gets merged

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@seeker25
Copy link
Collaborator

/gcbrun

@rodrigo-barraza rodrigo-barraza merged commit 41eed5b into bcgov:feature-business-registry-dashboard-updates Aug 24, 2023
7 checks passed
@pwei1018
Copy link
Collaborator

Temporary Url for review: https://bcregistry-account-dev--pr-2468-ozcq53tu.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seeker25 seeker25 seeker25 approved these changes

@Jxio Jxio Awaiting requested review from Jxio Jxio is a code owner

@ochiu ochiu Awaiting requested review from ochiu ochiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rodrigo-barraza @Jxio @pwei1018 @seeker25