Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12777 - Add in details field for invoice. This allows us to move some LEAR sp… #1881

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

seeker25
Copy link
Collaborator

@seeker25 seeker25 commented Jan 12, 2023

…ecific code out of SBC-PAY.

Issue #: /bcgov/entity#12777

Description of changes:

Code that is being moved over:
https://github.com/bcgov/sbc-pay/blob/dcf58b09e429199d6e42804b6a303993ec14098f/pay-api/src/pay_api/models/invoice.py#L180

Would be nice if it was deployed before:
bcgov/sbc-pay#1065

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@seeker25 seeker25 self-assigned this Jan 12, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.3% 21.3% Duplication

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #1881 (41358a2) into main (8a6aa0b) will decrease coverage by 1.11%.
The diff coverage is 49.21%.

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   78.25%   77.13%   -1.12%     
==========================================
  Files         188      189       +1     
  Lines       10286    10370      +84     
  Branches     1703     1721      +18     
==========================================
- Hits         8049     7999      -50     
- Misses       1709     1841     +132     
- Partials      528      530       +2     
Flag Coverage Δ
legalapi 76.92% <46.28%> (-1.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
legal-api/src/legal_api/models/filing.py 93.52% <ø> (ø)
legal-api/src/legal_api/services/authz.py 81.01% <ø> (ø)
.../src/entity_filer/filing_processors/dissolution.py 81.66% <ø> (ø)
...ty_filer/filing_processors/incorporation_filing.py 79.24% <ø> (ø)
legal-api/src/legal_api/reports/report.py 29.21% <7.03%> (-13.88%) ⬇️
...egal_api/resources/v1/business/business_filings.py 60.61% <33.33%> (-0.04%) ⬇️
...gal_api/services/filings/validations/validation.py 66.97% <33.33%> (-0.96%) ⬇️
legal-api/src/legal_api/core/filing.py 85.26% <55.55%> (-1.17%) ⬇️
...s/v2/business/business_filings/business_filings.py 57.80% <60.00%> (+0.19%) ⬆️
...gal_api/services/filings/validations/correction.py 76.76% <61.29%> (-6.13%) ⬇️
... and 29 more

@seeker25 seeker25 merged commit 5a6ce9f into bcgov:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants