12777 - System Exit 1 / Performance fixes for Invoice searching, also statement building #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeker25
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 91.53% 91.51% -0.02%
==========================================
Files 162 162
Lines 10626 10609 -17
==========================================
- Hits 9726 9709 -17
Misses 900 900
Flags with carried forward coverage won't be shown. Click here to find out more.
|
seeker25
changed the title
seeker25
commented
Jan 13, 2023
| @@ -213,19 +226,24 @@ def search_purchase_history(cls, # pylint:disable=too-many-arguments, too-many- | |||
|
|
|||
| if not return_all: | |||
| # Add pagination | |||
| pagination = query.paginate(per_page=limit, page=page) | |||
| result, count = pagination.items, pagination.total | |||
| sub_query = query.with_entities(Invoice.id).\ | |||
There was a problem hiding this comment.
query.paginate wouldn't seem to work for me. I've had a similar issue with routing slips before.
seeker25
commented
Jan 13, 2023
| @@ -48,8 +48,6 @@ | |||
|
|
|||
| LEGISLATIVE_TIMEZONE = 'America/Vancouver' | |||
| DT_SHORT_FORMAT = '%Y-%m-%d' | |||
| INCORPORATION_LABEL = 'Incorporation Number:' | |||
seeker25
commented
Jan 13, 2023
| @@ -175,15 +171,4 @@ def _clean_up(self, data, many): # pylint: disable=unused-argument | |||
| if data.get('status_code') == InvoiceStatus.PAID.value: | |||
| data['status_code'] = PaymentStatus.COMPLETED.value | |||
|
|
|||
| # If it's a BUSINESS invoice, then push details. | |||
|
|
|||
| if data.get('business_identifier', None): | |||
There was a problem hiding this comment.
Pay doesn't care about invoice details that should be provided from lear
This is also a huge performance hit when searching invoices
|
Kudos, SonarCloud Quality Gate passed!
|
kialj876
reviewed
Jan 13, 2023
| line_item_schema = PaymentLineItemSchema(exclude=('id', 'line_item_status_code')) | ||
| line_item_dict = line_item_schema.dump(payment_line_item) | ||
| line_item_dict['filing_type_code'] = payment_line_item.fee_schedule.filing_type_code | ||
| invoice['line_items'].append(line_item_dict) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
bcgov/entity#12777
Description of changes:
search_purchase_historyto use only needed fields and joinscreate_payment_report_detailsso it wont requery the database when the information is already availableBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).