Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formio modal bug fix #2161

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Formio modal bug fix #2161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a44df4
Add formio modal checker
djnunez-aot Sep 11, 2023
1a1a26d
update formioModalListener
djnunez-aot Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions met-web/src/components/FormioModalListener/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { useEffect } from 'react';
import { useLocation } from 'react-router-dom';

const FormioModalListener = () => {
const { pathname } = useLocation();

useEffect(() => {
const formioModal = document.querySelector('.formio-dialog');
if (formioModal) {
formioModal.remove();
}
}, [pathname]);

return null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the return null? Is it needed?

};

export default FormioModalListener;
2 changes: 2 additions & 0 deletions met-web/src/routes/AuthenticatedRoutes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,13 @@ import { USER_ROLES } from 'services/userService/constants';
import UserProfile from 'components/userManagement/userDetails';
import ScrollToTop from 'components/scrollToTop';
import ReportSettings from 'components/survey/report';
import FormioModalListener from 'components/FormioModalListener';

const AuthenticatedRoutes = () => {
return (
<>
<ScrollToTop />
<FormioModalListener />
<Routes>
<Route path="/" element={<Dashboard />} />
<Route path="/engagements" element={<EngagementListing />} />
Expand Down