Formio modal bug fix #2161
Merged
Formio modal bug fix #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djnunez-aot
requested review from
jadmsaadaot,
saravanpa-aot and
VineetBala-AOT
as code owners
jadmsaadaot
reviewed
Sep 12, 2023
| @@ -6,6 +6,10 @@ const ScrollToTop = () => { | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
I like this, can we please have it in its own separate component though. We can name it something relevant and specific to Formio. FormioModalListener... maybe
There was a problem hiding this comment.
For sure ill do that now
jadmsaadaot
suggested changes
Sep 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
- Coverage 68.95% 68.94% -0.02%
==========================================
Files 466 466
Lines 15039 15046 +7
Branches 1177 1184 +7
==========================================
+ Hits 10370 10373 +3
- Misses 4468 4472 +4
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more. |
jadmsaadaot
reviewed
Sep 13, 2023
| } | ||
| }, [pathname]); | ||
|
|
||
| return null; |
There was a problem hiding this comment.
why the return null? Is it needed?
jadmsaadaot
approved these changes
Sep 13, 2023
NatSquared
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Add formio modal checker * update formioModalListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #1327
-Add a listener that unrenders the formio modal on switching routes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).