Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formio modal bug fix #2161

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Formio modal bug fix #2161

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a44df4
Add formio modal checker
djnunez-aot Sep 11, 2023
1a1a26d
update formioModalListener
djnunez-aot Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions met-web/src/components/scrollToTop/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ const ScrollToTop = () => {

useEffect(() => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, can we please have it in its own separate component though. We can name it something relevant and specific to Formio. FormioModalListener... maybe

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure ill do that now

window.scrollTo(0, 0); // Scroll to the top of the page on route change
const formioModal = document.querySelector('.formio-dialog');
if (formioModal) {
formioModal.remove();
}
}, [pathname]);

return null;
Expand Down