Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proponent version of csv export #2209

Merged
merged 15 commits into from
Sep 18, 2023
Merged

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: #2136 #2133

Description of changes:

  • Backend changes to extract comment data for proponent. This will include comments that are viewable by the public i.e. approved comments and comments that are set as display in report settings.
  • Changed the notification util to check for single tenant environment to create the site url
  • Front end changes to move the export to csv button to the "Read all comments" page and add a drop down on the button to either select staff/proponent version to download.
  • Added new template for proponent version

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

Codecov Report

Merging #2209 (b4b5d95) into main (43df78a) will decrease coverage by 0.18%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##             main    #2209      +/-   ##
==========================================
- Coverage   68.78%   68.61%   -0.18%     
==========================================
  Files         469      469              
  Lines       15232    15279      +47     
  Branches     1183     1182       -1     
==========================================
+ Hits        10477    10483       +6     
- Misses       4555     4596      +41     
  Partials      200      200              
Flag Coverage Δ
metapi 76.92% <41.17%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
met-web/src/apiManager/endpoints/index.ts 100.00% <ø> (ø)
...nents/comments/admin/reviewListing/Submissions.tsx 81.39% <ø> (-3.52%) ⬇️
met-web/src/services/commentService/index.tsx 36.36% <ø> (-2.10%) ⬇️
met-api/src/met_api/services/comment_service.py 68.20% <14.28%> (-13.81%) ⬇️
met-api/src/met_api/models/comment.py 73.22% <33.33%> (-1.98%) ⬇️
met-api/src/met_api/utils/notification.py 64.28% <75.00%> (+1.78%) ⬆️
met-api/src/met_api/resources/comment.py 79.24% <76.47%> (-10.50%) ⬇️
met-api/src/met_api/utils/enums.py 100.00% <100.00%> (ø)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@VineetBala-AOT VineetBala-AOT marked this pull request as ready for review September 18, 2023 18:08
@VineetBala-AOT VineetBala-AOT merged commit fa7f4d2 into bcgov:main Sep 18, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Changes to show all survey results to superusers

* removing hard coded values

* fixing linting

* splitting to seperate end points

* fixing auth check

* fixing linting

* merging method in service

* Handle no data error for graphs

* adding new nodata component

* adding new email for submission response

* fixing linting and testing

* Upgrades to Issue Tracking Table

* removing try catch

* Adding proponent version of csv export

* fixing unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants