Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the ordering of comments on export csv #2218

Merged
merged 14 commits into from
Sep 19, 2023

Conversation

VineetBala-AOT
Copy link
Collaborator

Issue #: #2136

Description of changes:

  • Updating the ordering of comments on export csv
  • Enable auto close of drop down after the export

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #2218 (2736246) into main (2599092) will increase coverage by 0.02%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##             main    #2218      +/-   ##
==========================================
+ Coverage   68.45%   68.47%   +0.02%     
==========================================
  Files         471      471              
  Lines       15484    15494      +10     
  Branches     1204     1204              
==========================================
+ Hits        10599    10609      +10     
  Misses       4681     4681              
  Partials      204      204              
Flag Coverage Δ
metapi 76.58% <76.92%> (+0.01%) ⬆️
metweb 61.47% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/components/comments/admin/textListing/index.tsx 85.43% <50.00%> (+1.27%) ⬆️
met-api/src/met_api/services/comment_service.py 69.06% <76.92%> (+0.85%) ⬆️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@VineetBala-AOT VineetBala-AOT merged commit 8c67e4a into bcgov:main Sep 19, 2023
16 checks passed
NatSquared pushed a commit that referenced this pull request Oct 19, 2023
* Changes to show all survey results to superusers

* removing hard coded values

* fixing linting

* splitting to seperate end points

* fixing auth check

* fixing linting

* merging method in service

* Handle no data error for graphs

* adding new nodata component

* adding new email for submission response

* fixing linting and testing

* Upgrades to Issue Tracking Table

* removing try catch

* Fixing the comment order on export csv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants