[To Feature ] DESENG-605 - Adding Unit test #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o DESENG-605-TenantBackend
…o DESENG-605-TenantBackend
…o DESENG-605-TenantBackend
…o DESENG-605-TenantBackend
…o DESENG-605-TenantBackend
NatSquared
approved these changes
May 22, 2024
| @@ -188,6 +188,8 @@ const config: Config.InitialOptions = { | |||
|
|
|||
| // Whether to use watchman for file crawling | |||
| // watchman: true, | |||
|
|
|||
| testTimeout: 10000, | |||
There was a problem hiding this comment.
Were these tests timing out when running locally?
There was a problem hiding this comment.
sometimes old tests also timing out locally
| ); | ||
|
|
||
| const loadingTexts = screen.getAllByText('Loading...'); | ||
| expect(loadingTexts.length).toBeGreaterThan(0); // Adjust based on expected occurrences |
There was a problem hiding this comment.
Was this left in intentionally?
| expect(screen.getByText('Contact One')).toBeVisible(); | ||
| expect(screen.getByText('contactone@example.com')).toBeVisible(); | ||
| expect(screen.getByText('Photographer One')).toBeVisible(); | ||
| expect(screen.getByText('Logo Description One')).toBeVisible(); |
There was a problem hiding this comment.
I appreciate how thorough these tests are :)
NatSquared
reviewed
May 22, 2024
| import * as reactRouter from 'react-router'; | ||
| import * as tenantService from 'services/tenantService'; | ||
| import TenantDetail from '../../../../src/components/tenantManagement/Detail'; | ||
| import { MemoryRouter, Route, Routes, useParams } from 'react-router-dom'; |
There was a problem hiding this comment.
Just noticed this unused import :p
Suggested change
| import { MemoryRouter, Route, Routes, useParams } from 'react-router-dom'; | |
| import { MemoryRouter, Route, Routes} from 'react-router-dom'; |
NatSquared
reviewed
May 22, 2024
| import * as reactRedux from 'react-redux'; | ||
| import * as reactRouter from 'react-router'; | ||
| import * as tenantService from 'services/tenantService'; | ||
| import { draftEngagement } from '../factory'; |
There was a problem hiding this comment.
this is unused too 🙃
Suggested change
| import { draftEngagement } from '../factory'; |
|
NatSquared
added a commit
that referenced
this pull request
May 24, 2024
* [To Feature Branch] - DESENG-605 - Tenant backend api (#2508) * DESENG-605: Tenant API and Unit test * DESENG-605 - Add Tenant - Frontend UI (#2510) * DESENG-605 - Tenant detail page (#2511) * DESENG-605: Tenant API and Unit test * DESENG-605: Tenant detail page * DESENG-606: Add tenant edit page (#2513) * DESENG-605: Delete tenant flow * DESENG-605 - Delete tenant functionality (#2515) * DESENG-605 - Adding Unit test (#2518) * DESENG-605: Tenant unit test for listing and detail * Multi tenancy - UX Pass 1 (#2519) * DESENG-605-606-unit-tests (#2522) * Frontend unit tests * Update changelog --------- Co-authored-by: Ratheesh kumar R <ratheesh.kumar@aot-technologies.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-605
Description of changes:
Added unit test for Tenant listing and Tenant Detail page
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).