Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[To Main] Tenant CRUD implementation #2524

Merged
merged 19 commits into from
May 24, 2024
Merged

Conversation

NatSquared
Copy link
Contributor

@NatSquared NatSquared commented May 23, 2024

Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-605
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-606

This PR consists of pre-approved changes:
#2508
#2510
#2511
#2512
#2513
#2515
#2518
#2519
#2522

Description of changes:

  • Feature Finish tenant management UX
    • Added a new tenant detail page
    • Added a form for filling out tenant details
    • Added a new tenant creation page
    • Added a new tenant edit page

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).

ratheesh-aot and others added 16 commits May 16, 2024 09:18
* DESENG-605: Tenant API and Unit test

* Fixed merge conflicts
* Initial commit - create tenant frontend

* Add field validation

* make tenant form context independent
* DESENG-605: Tenant API and Unit test

* Fixed merge conflicts

* DESENG-605: Tenant detail page

* DESENG-605: Tenant detail page
* Initial version of tenant edit form + backend updates

* Make sure form is properly updated by image uploads
* DESENG-605: Tenant API and Unit test

* Fixed merge conflicts

* DESENG-605: Tenant detail page

* DESENG-605: Tenant detail page

* DESENG-605: Delete tenant flow
* DESENG-605: Tenant API and Unit test

* Fixed merge conflicts

* DESENG-605: Tenant detail page

* DESENG-605: Tenant detail page

* DESENG-605: Delete tenant flow

* DESENG-605: Tenant unit test for listing and detail

* Updated with review comments
* DESENG 418: Multi tenancy general UX pass

* update text input focus state; fix linter errors

* Add email copy button

* Accessibility for clickable table entries
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 82.23801% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 76.04%. Comparing base (4993462) to head (b0555d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2524      +/-   ##
==========================================
+ Coverage   75.81%   76.04%   +0.23%     
==========================================
  Files         597      617      +20     
  Lines       21432    22093     +661     
  Branches     1575     1686     +111     
==========================================
+ Hits        16249    16801     +552     
- Misses       4926     5028     +102     
- Partials      257      264       +7     
Flag Coverage Δ
metapi 87.98% <88.18%> (+0.04%) ⬆️
metweb 64.73% <80.50%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
met-api/src/met_api/models/tenant.py 100.00% <100.00%> (ø)
met-api/src/met_api/schemas/tenant.py 100.00% <100.00%> (ø)
met-api/src/met_api/services/tenant_service.py 95.38% <100.00%> (+20.38%) ⬆️
met-web/src/apiManager/endpoints/index.ts 100.00% <ø> (ø)
met-web/src/components/common/Input/FormField.tsx 100.00% <100.00%> (ø)
met-web/src/components/common/Input/TextInput.tsx 100.00% <100.00%> (ø)
met-web/src/components/common/Input/index.tsx 100.00% <100.00%> (ø)
met-web/src/components/common/Layout/index.tsx 81.81% <100.00%> (ø)
...eb/src/components/common/Navigation/Breadcrumb.tsx 100.00% <100.00%> (ø)
met-web/src/components/common/index.tsx 92.22% <ø> (ø)
... and 16 more

... and 5 files with indirect coverage changes

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
4 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@NatSquared NatSquared marked this pull request as ready for review May 23, 2024 23:19
@NatSquared NatSquared enabled auto-merge (squash) May 23, 2024 23:44
Copy link
Collaborator

@ratheesh-aot ratheesh-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NatSquared NatSquared merged commit 0959d82 into main May 24, 2024
15 checks passed
@NatSquared NatSquared deleted the DESENG-605-TenantCRUDMain branch June 26, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants