-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[To Main] Tenant CRUD implementation #2524
Conversation
* DESENG-605: Tenant API and Unit test * Fixed merge conflicts
* Initial commit - create tenant frontend * Add field validation * make tenant form context independent
* DESENG-605: Tenant API and Unit test * Fixed merge conflicts * DESENG-605: Tenant detail page * DESENG-605: Tenant detail page
* Initial version of tenant edit form + backend updates * Make sure form is properly updated by image uploads
* DESENG-605: Tenant API and Unit test * Fixed merge conflicts * DESENG-605: Tenant detail page * DESENG-605: Tenant detail page * DESENG-605: Delete tenant flow
* DESENG-605: Tenant API and Unit test * Fixed merge conflicts * DESENG-605: Tenant detail page * DESENG-605: Tenant detail page * DESENG-605: Delete tenant flow * DESENG-605: Tenant unit test for listing and detail * Updated with review comments
* DESENG 418: Multi tenancy general UX pass * update text input focus state; fix linter errors * Add email copy button * Accessibility for clickable table entries
* Frontend unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
+ Coverage 75.81% 76.04% +0.23%
==========================================
Files 597 617 +20
Lines 21432 22093 +661
Branches 1575 1686 +111
==========================================
+ Hits 16249 16801 +552
- Misses 4926 5028 +102
- Partials 257 264 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-605
Issue #: https://apps.itsm.gov.bc.ca/jira/browse/DESENG-606
This PR consists of pre-approved changes:
#2508
#2510
#2511
#2512
#2513
#2515
#2518
#2519
#2522
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0).