17505 Create a loop to attempt retrieval of payment records from the payment queue callback up to a maximum of five times #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
…payment queue call back
eve-git
requested review from
pwei1018,
thorwolpert,
stevenc987,
mengdong19,
ozamani9gh and
rarmitag
as code owners
seeker25
reviewed
Sep 19, 2023
There was a problem hiding this comment.
We should probably throw an exception on line 259, that way the queue will reprocess the message if the retry fails.
There was a problem hiding this comment.
@seeker25 please review
There was a problem hiding this comment.
Looks good, you might not need the retry loop with the exception being thrown, but I think this is ok for now.
Would recommend removing lines on 198, 199
|
Kudos, SonarCloud Quality Gate passed!
|
seeker25
approved these changes
Sep 22, 2023
bolyachevets
approved these changes
Sep 22, 2023
ozamani9gh
reviewed
Sep 25, 2023
ozamani9gh
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
17505
Description of changes:
Create a loop to attempt retrieval of payment records from the payment queue callback up to a maximum of five times
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).