Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17505 Create a loop to attempt retrieval of payment records from the payment queue callback up to a maximum of five times #1417
17505 Create a loop to attempt retrieval of payment records from the payment queue callback up to a maximum of five times #1417
Changes from all commits
e53e7d8
7abcb93
25faad9
11a627a
2882238
a83b573
df71b6b
60a44ad
5b16c9f
c3dc8e2
2d5c7c3
9f72d8e
e8af876
d65030f
ceb84bc
2b10ee8
d4ab0eb
df41efb
ce66a32
25bf1fc
d23cee3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably throw an exception on line 259, that way the queue will reprocess the message if the retry fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seeker25 please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, you might not need the retry loop with the exception being thrown, but I think this is ok for now.
Would recommend removing lines on 198, 199