feat(BE:FSADT1-740): implementing client submission list and refactors #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
April 13, 2023 08:59
Some requests can return an error due to the amount of requests being done to orgbook.
github-actions
bot
added
backend
paulushcgcj
requested review from
brunoMarchiEncora and
mamartinezmejia
as code owners
* fix(be): - Changed the version of the jacobo plugin as the version 0.8.9 was failing locally * fix(fe): - Fixed deprecation warning message indicating that the 'importsNotUsedAsValues' option will be removed in TypeScript 5.5, and we should use the 'verbatimModuleSyntax' instead. * Partial commit to get changes from Paulo * This code is not longer needed * Reverted changed. Done for testing purposes. * Changed named to legal name as the current one is misleading as we are using both client type and legal type * feat(fe): - Draft for https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT1-722 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #2 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #3 * Uncommented out code * feat(fe): - Completed FSADT1-722 * chore: fixing tests --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
|
[forest-client-frontend] Kudos, SonarCloud Quality Gate passed!
|
mamartinezmejia
approved these changes
Apr 19, 2023
brunoMarchiEncora
approved these changes
Apr 19, 2023
This was referenced Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the endpoint to list client submissions along with filter and pagination mechanism
Fixes FSADT1-740
Type of change
Please delete options that are not relevant.
Further comments
This also includes some quality of life code changes, such as the removal of two endpoints that weren't used at all
Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Legacy available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow