Add missing topics #2
Assignees
Comments
|
Hey, its been 121 days since this PR was last updated. I'm sure everyone is busy, however, it would be appreciated if someone from the team puts this issue to bed. Thanks in Advance. |
mamartinezmejia
added a commit
that referenced
this issue
Nov 10, 2022
mamartinezmejia
added a commit
that referenced
this issue
Jan 30, 2023
- Renamed some fields to avoid confusions with HTML element properties - Part #2 - Renamed some fields to a more meaninful name
Merged
mamartinezmejia
added a commit
that referenced
this issue
Feb 27, 2023
mamartinezmejia
added a commit
that referenced
this issue
Mar 15, 2023
* no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
paulushcgcj
pushed a commit
that referenced
this issue
Mar 16, 2023
* no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
paulushcgcj
pushed a commit
that referenced
this issue
Mar 16, 2023
* no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
paulushcgcj
pushed a commit
that referenced
this issue
Mar 16, 2023
* no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
paulushcgcj
pushed a commit
that referenced
this issue
Mar 17, 2023
* feat(FSADT1-639): adding bcregistry details backend * feature(FSADT1-639): adding loading on frontend * feature(FSADT1-639): adding bc registry params for deployment * feat: updating form to load addresses * chore(deps): update registry.access.redhat.com/ubi8/ubi docker tag to v8.7-1090 * fix(deps): update dependency org.springframework.boot:spring-boot-starter-parent to v3.0.4 * chore(deps): update dependency maven-wrapper to v3.2.0 * chore(deps): update maven all non-major dependencies * fix(deps): update vitest monorepo to ^0.29.0 * chore(deps): update dependency org.apache.maven.plugins:maven-failsafe-plugin to v3 * chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3 * chore(deps): update linters * chore(deps): update postgres docker tag to v15 * Frontend improvements (#400) * no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * Frontend improvements (#400) * no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * Frontend improvements (#400) * no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * Change backend and legacy to matrix format on github action (#404) * chore: Change backend and legacy to matrix format on github action (#404) * fix: fixing class parameter names * chore: updating workflow * fix: fixing workflow var and unifying secrets - moving all secrets to init - fixing variables used on workflow that missed the $ character - renamed the secrets to be a single one - moved vault stage to init step * ci: fixing deploy of init * Add single quotes to Vault vars * Update README.md (#406) * Update README.md * Update README.md * Bump deployer action version * fix: fixing variable with space issue * doc: updating swagger documentation * fix: fixing secrets * fix: reverting version for test --------- Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> Co-authored-by: brunoMarchiEncora <117365587+brunoMarchiEncora@users.noreply.github.com> Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
This was referenced Mar 17, 2023
mamartinezmejia
added a commit
that referenced
this issue
Apr 4, 2023
mamartinezmejia
added a commit
that referenced
this issue
Apr 5, 2023
* no message * fix(fe/be): - Fixed validation messages on the BE - Fixed missing return in validation messages component - Added missing validation in contacts section - Refactored code in both FE and BE - Beautified code * fix(be): - Fixed as per recommended (WhitespaceAround: '+' is not followed by whitespace.) * feat(be): - Cleaned and organized imports * feat(fe/be): - Improved code after code reviews * feat/fix(be): - Fixed unit testting bug - Cleaned imports - Beautified code for better readibility * Revert "feat(be):" This reverts commit 12b8122. * fix(be): - Made code reviews * fix(be): - Fixed code smell issues #1 * fix(be): - Removed extra separation in import group to satisfy SonarCloud * fix(be): - Fixed code smell issues #2 * fix(be): - Fixed code smell issues #3 * fix(be): - Code reviews: Defined a constant instead of duplicating literal * fix(be): - Reverted change as I had it before * fix(be): - Fixed typo * fix(be): - Changed field to businessName as the incorporation number is hidden in the UI * fix(be): - Fixed based on code reviews standard - Fixed code smells. Need to discuss this with the team as this doesn't make sense.
mamartinezmejia
added a commit
that referenced
this issue
Apr 12, 2023
* no message * fix(fe/be): - Fixed validation messages on the BE - Fixed missing return in validation messages component - Added missing validation in contacts section - Refactored code in both FE and BE - Beautified code * fix(be): - Fixed as per recommended (WhitespaceAround: '+' is not followed by whitespace.) * feat(be): - Cleaned and organized imports * feat(fe/be): - Improved code after code reviews * feat/fix(be): - Fixed unit testting bug - Cleaned imports - Beautified code for better readibility * Revert "feat(be):" This reverts commit 12b8122. * fix(be): - Made code reviews * fix(be): - Fixed code smell issues #1 * fix(be): - Removed extra separation in import group to satisfy SonarCloud * fix(be): - Fixed code smell issues #2 * fix(be): - Fixed code smell issues #3 * fix(be): - Code reviews: Defined a constant instead of duplicating literal * fix(be): - Reverted change as I had it before * fix(be): - Fixed typo * fix(be): - Changed field to businessName as the incorporation number is hidden in the UI * fix(be): - Fixed based on code reviews standard - Fixed code smells. Need to discuss this with the team as this doesn't make sense. * feat(fe): - Removed error msgs when value changes * feat(BE): updating bc registry to use document requisition * feat(fe): - FSADT1-736 * fix(be): - Changed wording as per suggested by Paulo --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
mamartinezmejia
added a commit
that referenced
this issue
Apr 18, 2023
…e using both client type and legal type #2
mamartinezmejia
added a commit
that referenced
this issue
Apr 19, 2023
* fix(be): - Changed the version of the jacobo plugin as the version 0.8.9 was failing locally * fix(fe): - Fixed deprecation warning message indicating that the 'importsNotUsedAsValues' option will be removed in TypeScript 5.5, and we should use the 'verbatimModuleSyntax' instead. * Partial commit to get changes from Paulo * This code is not longer needed * Reverted changed. Done for testing purposes. * Changed named to legal name as the current one is misleading as we are using both client type and legal type * feat(fe): - Draft for https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT1-722 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #2 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #3 * Uncommented out code * feat(fe): - Completed FSADT1-722 * chore: fixing tests --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
paulushcgcj
pushed a commit
that referenced
this issue
Apr 19, 2023
* fix(be): - Changed the version of the jacobo plugin as the version 0.8.9 was failing locally * fix(fe): - Fixed deprecation warning message indicating that the 'importsNotUsedAsValues' option will be removed in TypeScript 5.5, and we should use the 'verbatimModuleSyntax' instead. * Partial commit to get changes from Paulo * This code is not longer needed * Reverted changed. Done for testing purposes. * Changed named to legal name as the current one is misleading as we are using both client type and legal type * feat(fe): - Draft for https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT1-722 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #2 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #3 * Uncommented out code * feat(fe): - Completed FSADT1-722 * chore: fixing tests --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>
paulushcgcj
pushed a commit
that referenced
this issue
Apr 20, 2023
#436) * feat: adding proxy timeout config to legacy * fix: adding error handler to orgbook Some requests can return an error due to the amount of requests being done to orgbook. * fix: updating timeout for legacy * chore: removing unwanted endpoints * chore: removing unwanted endpoints * feat(BE:FSADT1-740): reworking submission to include list * chore: cleaning up validator * chore: removing submission from client * chore: refactoring ches service to include validation * chore: updating enum to be more flexible * chore: adding display name to make it easier to read * feat(BE:FSADT1-740): adding dto and predicates for search * chore: removing unwanted file * chore: simplifying validators * chore: renaming predicate class * chore: supressing warning * chore: code restructuring * chore: updating tests * FSADT1-722 (#435) * fix(be): - Changed the version of the jacobo plugin as the version 0.8.9 was failing locally * fix(fe): - Fixed deprecation warning message indicating that the 'importsNotUsedAsValues' option will be removed in TypeScript 5.5, and we should use the 'verbatimModuleSyntax' instead. * Partial commit to get changes from Paulo * This code is not longer needed * Reverted changed. Done for testing purposes. * Changed named to legal name as the current one is misleading as we are using both client type and legal type * feat(fe): - Draft for https://apps.nrs.gov.bc.ca/int/jira/browse/FSADT1-722 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #2 * Changed named to legal name as the current one is misleading as we are using both client type and legal type #3 * Uncommented out code * feat(fe): - Completed FSADT1-722 * chore: fixing tests --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
mamartinezmejia
added a commit
that referenced
this issue
Sep 14, 2023
mamartinezmejia
added a commit
that referenced
this issue
Sep 25, 2023
mamartinezmejia
added a commit
that referenced
this issue
Sep 25, 2023
mamartinezmejia
added a commit
that referenced
this issue
Sep 25, 2023
paulushcgcj
pushed a commit
that referenced
this issue
Oct 10, 2023
paulushcgcj
pushed a commit
that referenced
this issue
Oct 10, 2023
paulushcgcj
pushed a commit
that referenced
this issue
Oct 10, 2023
paulushcgcj
pushed a commit
that referenced
this issue
Oct 10, 2023
paulushcgcj
added a commit
that referenced
this issue
Oct 23, 2023
* fix: fixing progress state when error * fix: fixing error notification Fixing error notification below progress indication. * fix: fixing dropdown * fix: fixing multi select * chore: updating stubs to add more addresses * fix: fixing dropdown not changing when selection change * feat: add formErrors variable * chore: redoing css changes - Part #1 * feat: display address extra errors * feat: move extra errors to the error component * chore: redoing css changes - Part #2 * feat: replace formErrors argument with notification approach * feat: scroll to new contact * feat: add callback argument to useFocus * feat: make the bindings to create and scroll to new contact * chore: minor adjusments on useFocus * chore: redoing css changes - Part #3 * chore: redoing css changes - Part #4 * test: test the validation function and the error component * fix: update contactType value on select * test: ignore already valid location * test: remove outdated test * feat: add parameter for the shadow directive * feat: display progress indicator vertically Also adds some changes for displaying it horizontally. * FSADT1-868: Allowed special characters. Done olnly in the Frontend as the Backend was already allowing special charactes. * test: add getMany command * test: add progress indicator tests * fixed inline notification colors * Removed wrong style * Added property needed * feat: show logout modal * refactor: unify code for the logout button in different sizes * feat: show help modal * feat: use media query instead of outerWidth to determine screen size * Removed class that was causing issues with the logout button * Revert "Removed class that was causing issues with the logout button" This reverts commit 827e496. * Fixed logout button * feat: adjust header buttons * Fixed mask issue with the postal code * Renamed some files before refactoring code * no message * Made code reviews * chore: remove console.log * fix: prevent an older request from overwriting the results * Made requiered changes * Removed repeatead code * Removed unneeded setting * fix: do not always block response from older request It should be allowed when no newer request was yet responded. * chore: use simple counter to generate requestId * fix: init fetching * test: fix test * Fixed file * Added javadoc comment as per requested by SonarCloud * docs: improve comment * feat: adjust header logo and buttons * feat: adjust header spaces and breakpoints * chore: use date milliseconds as id * fix: fix build issue * fix: prevent error in the workflow * fix: attempt to fix tests in the workflow * fix: remove package from optimizeDeps As an attempt to prevent error in the workflow. * refactor: requested changes from review * Refactored code - Part #1 * Made code reviews * Formatted and beautified code * style: small changes to code style * chore: fix code linter * Refactored code - Part #1.1 * fix: Fixed sonarcloud security hotspot issue * fix: Fixed security hotspot * Refactored code - Part #2 * Refactored code - Part #2.1 * fix: fix header small screen * fix: attempt to fix side effect in the workflow * chore: submitting small changes * fix(FSADT1-884): fixing steps being enable - adjusted the steps to be disable by default - only enable if valid and only for the next step * chore: sorting import * fix(FSADT1-887): fixing typo on step 4 * fix(FSADT1-889): fixing font style * fix: Fixed security hotspot and improved wording * fix: Fixed security hotspot * fix(FSADT1-888): fixing spacing between radio buttons * Trying a different approach to solve the security hotspot issue * fix(FSADT1-892): fixing submission page * Trying a different approach to solve the security hotspot issue #2 * fix(FSADT1-894): fixing field spacing and width * fix(FSADT1-891): fixing modal spacing * fix(FSADT1-889): fixing notification body content * fix(FSADT1-890): fixing component alignment * fix: Fixed security hotspot * fix: Fixed security hotspot * Made code reviews * Removed unused variable * Refactored code and made code reviews * feat: adjust margins * fix(FSADT1-884): removing navigation link * Made code reviews * fix: header height * chore: replace mock e-mail from .local to .com * fix: do not pre-validate current step * feat: replace margin with padding * FSADT1-899: Removed unneeded validation * ci: updating trivy to fix issues * no message * no message * Tried to skip SonarCloud validation * Skipped SonarCloud validation * chore: adding us address stub data * fix(FSADT1-884): fixing subtitle style * fix: autocomplete after changing country * fix: fix subtitle style for vertical progress indicator * fis(FSADT1-894): fixing style for inline and text * Made code reviews * FSADT1-879 * - Made code reviews - Removed unused code * Made code reviews * Made code reviews * Made improvement * feat: clear text displayed on combo-box * fix: clear text displayed on combo-box Without using any private properties from the component. * refactor: move iteration props * fix: fix link to bceid * chore: remove unused import * fix: remove placeholders on country and province * fix: fix casing for Business information * fix: fix doc coment closing For some reason this was messing the code displayed in the Chrome browser sources. * fix: conditions used on postalCode validations * chore: fix VS Code resolution for source and test files By fixing the test configuration and eliminating a conflict with the app one. * test: use a new query command after a click Since it's unsafe to chain after a click. * test: force click button * fix: prevent completing business step with invalid data * fix: prevent fetching for name "undefined" * test: wait before clicking the option * Made a minor change for internal emails after a conversation with Andrew. * style: add semi-colon as requested after review * style: add the dollar signal to all conditions * feat: turn the dollar signal required * Made code reviews * Made more code reviews * Made this to prevent perisisting information mutliple times * test: wait for the option's inner element to become visible * fix: emit error always for text-input Instead of only when the error changes. * fix: update error status on Address step text fields So to be able to properly make it valid later when it gets resolved. * fix: update Street address empty status properly * test: emit empty true when contents is empty * docs: refer specific Jira issue * fix: - Renamed variable and added an new property to make it more generic - Beautified code * fix: - Renamed variable and added an new property in test file * fix: Made code reviews and removed unneeded prop I added * fix: update error status on Contacts step text fields So to be able to properly make it valid later when it gets resolved. * test: emit valid events properly * no message * fix: - Renamed variable with a proper name - Made code reviews * docs: improve comment * docs: improve comment * fix: synchronize dropdown value * fix: get country validation * fix: validate after changed from outside * test: define some tests to be implemented * test: province gets cleared * docs: add issue references * test: revalidates when changed from outside Also fixes another test. * Fast commit to switch branches * fix: validate the item code instead of its name * test: update tests * fix: remove meaningless tag * fix: do not display field as invalid When the field is empty and user didn't have a chance to add its value yet. For example, when it gets auto-changed as a result of changing another field. * Fast commit to switch branches * fix: Made code reviews and added birth date field * fix: Fixed logo for small screens * test: do not emit error in specific situation * feat: use variable to tell if selection was a user event * test: update tests * chore: use variable to tell if the change was a user event * test: update test * feat: add tooltip to button Next * fix: proceed applying part to next level Regardless of current element already having a part attribute. * chore: adjust combo-boxes focus outline * Fast commit to switch branches * Modified gitignore * feat: - Removed unused code - Made code reviews * feat: - Made more code reviews * Fast commit to switch branches * Renamed class with a more generic name * Fast commit to switch branches * Made more code reviews * Fast commit to switch branches * Pushed common functions * Fast commit to switch branches * fix: fix AutoComplete events - fix empty value; - always emit the error; - do not validate at each key pressed. * test: add empty and error tests * fix: fix initial empty value * removed unneeded key * fix: allow selecting item identical to the typed value * test: update test * Fast commit to switch branches * test: add address group test * Fast commit to switch branches * test: fix import * feat: show loading icon on auto-complete fields * feat: allow some time before showing the loading icon * chore: add helper text * fix: validate multi-select field * fix: remove deleted address from contacts * Fast commit to switch branches * chore: small fix to remove extra spaces on the first step * - Made code reviews - Improve code and made it more genetic * Made code reviews * FSADT1-928 * Fixed code smell issues * Fixed code smell issues * Create unit test * chore: forcing update * Changed annotation * Renamed file as it had a typo * chore: apply custom directives to unit tests * Fixed some smell issues * test: attempt to fix test on github actions * Made more code reviews * Made more code reviews * chore: adjust Application submitted breakpoints * chore: adjust margins on Application submitted * fix: adjust header buttons breakpoint Import missing variable. * Added more coverage * Beautified CSS file --------- Co-authored-by: Fernando Terra <fernando.terra@encora.com> Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
1 task
paulushcgcj
added a commit
that referenced
this issue
Oct 23, 2023
* fix: fixing progress state when error * fix: fixing error notification Fixing error notification below progress indication. * fix: fixing dropdown * fix: fixing multi select * chore: updating stubs to add more addresses * fix: fixing dropdown not changing when selection change * feat: add formErrors variable * chore: redoing css changes - Part #1 * feat: display address extra errors * feat: move extra errors to the error component * chore: redoing css changes - Part #2 * feat: replace formErrors argument with notification approach * feat: scroll to new contact * feat: add callback argument to useFocus * feat: make the bindings to create and scroll to new contact * chore: minor adjusments on useFocus * chore: redoing css changes - Part #3 * chore: redoing css changes - Part #4 * test: test the validation function and the error component * fix: update contactType value on select * test: ignore already valid location * test: remove outdated test * feat: add parameter for the shadow directive * feat: display progress indicator vertically Also adds some changes for displaying it horizontally. * FSADT1-868: Allowed special characters. Done olnly in the Frontend as the Backend was already allowing special charactes. * test: add getMany command * test: add progress indicator tests * fixed inline notification colors * Removed wrong style * Added property needed * feat: show logout modal * refactor: unify code for the logout button in different sizes * feat: show help modal * feat: use media query instead of outerWidth to determine screen size * Removed class that was causing issues with the logout button * Revert "Removed class that was causing issues with the logout button" This reverts commit 827e496. * Fixed logout button * feat: adjust header buttons * Fixed mask issue with the postal code * Renamed some files before refactoring code * no message * Made code reviews * chore: remove console.log * fix: prevent an older request from overwriting the results * Made requiered changes * Removed repeatead code * Removed unneeded setting * fix: do not always block response from older request It should be allowed when no newer request was yet responded. * chore: use simple counter to generate requestId * fix: init fetching * test: fix test * Fixed file * Added javadoc comment as per requested by SonarCloud * docs: improve comment * feat: adjust header logo and buttons * feat: adjust header spaces and breakpoints * chore: use date milliseconds as id * fix: fix build issue * fix: prevent error in the workflow * fix: attempt to fix tests in the workflow * fix: remove package from optimizeDeps As an attempt to prevent error in the workflow. * refactor: requested changes from review * Refactored code - Part #1 * Made code reviews * Formatted and beautified code * style: small changes to code style * chore: fix code linter * Refactored code - Part #1.1 * fix: Fixed sonarcloud security hotspot issue * fix: Fixed security hotspot * Refactored code - Part #2 * Refactored code - Part #2.1 * fix: fix header small screen * fix: attempt to fix side effect in the workflow * chore: submitting small changes * fix(FSADT1-884): fixing steps being enable - adjusted the steps to be disable by default - only enable if valid and only for the next step * chore: sorting import * fix(FSADT1-887): fixing typo on step 4 * fix(FSADT1-889): fixing font style * fix: Fixed security hotspot and improved wording * fix: Fixed security hotspot * fix(FSADT1-888): fixing spacing between radio buttons * Trying a different approach to solve the security hotspot issue * fix(FSADT1-892): fixing submission page * Trying a different approach to solve the security hotspot issue #2 * fix(FSADT1-894): fixing field spacing and width * fix(FSADT1-891): fixing modal spacing * fix(FSADT1-889): fixing notification body content * fix(FSADT1-890): fixing component alignment * fix: Fixed security hotspot * fix: Fixed security hotspot * Made code reviews * Removed unused variable * Refactored code and made code reviews * feat: adjust margins * fix(FSADT1-884): removing navigation link * Made code reviews * fix: header height * chore: replace mock e-mail from .local to .com * fix: do not pre-validate current step * feat: replace margin with padding * FSADT1-899: Removed unneeded validation * ci: updating trivy to fix issues * no message * no message * Tried to skip SonarCloud validation * Skipped SonarCloud validation * chore: adding us address stub data * fix(FSADT1-884): fixing subtitle style * fix: autocomplete after changing country * fix: fix subtitle style for vertical progress indicator * fis(FSADT1-894): fixing style for inline and text * Made code reviews * FSADT1-879 * - Made code reviews - Removed unused code * Made code reviews * Made code reviews * Made improvement * feat: clear text displayed on combo-box * fix: clear text displayed on combo-box Without using any private properties from the component. * refactor: move iteration props * fix: fix link to bceid * chore: remove unused import * fix: remove placeholders on country and province * fix: fix casing for Business information * fix: fix doc coment closing For some reason this was messing the code displayed in the Chrome browser sources. * fix: conditions used on postalCode validations * chore: fix VS Code resolution for source and test files By fixing the test configuration and eliminating a conflict with the app one. * test: use a new query command after a click Since it's unsafe to chain after a click. * test: force click button * fix: prevent completing business step with invalid data * fix: prevent fetching for name "undefined" * test: wait before clicking the option * Made a minor change for internal emails after a conversation with Andrew. * style: add semi-colon as requested after review * style: add the dollar signal to all conditions * feat: turn the dollar signal required * Made code reviews * Made more code reviews * Made this to prevent perisisting information mutliple times * test: wait for the option's inner element to become visible * fix: emit error always for text-input Instead of only when the error changes. * fix: update error status on Address step text fields So to be able to properly make it valid later when it gets resolved. * fix: update Street address empty status properly * test: emit empty true when contents is empty * docs: refer specific Jira issue * fix: - Renamed variable and added an new property to make it more generic - Beautified code * fix: - Renamed variable and added an new property in test file * fix: Made code reviews and removed unneeded prop I added * fix: update error status on Contacts step text fields So to be able to properly make it valid later when it gets resolved. * test: emit valid events properly * no message * fix: - Renamed variable with a proper name - Made code reviews * docs: improve comment * docs: improve comment * fix: synchronize dropdown value * fix: get country validation * fix: validate after changed from outside * test: define some tests to be implemented * test: province gets cleared * docs: add issue references * test: revalidates when changed from outside Also fixes another test. * Fast commit to switch branches * fix: validate the item code instead of its name * test: update tests * fix: remove meaningless tag * fix: do not display field as invalid When the field is empty and user didn't have a chance to add its value yet. For example, when it gets auto-changed as a result of changing another field. * Fast commit to switch branches * fix: Made code reviews and added birth date field * fix: Fixed logo for small screens * test: do not emit error in specific situation * feat: use variable to tell if selection was a user event * test: update tests * chore: use variable to tell if the change was a user event * test: update test * feat: add tooltip to button Next * fix: proceed applying part to next level Regardless of current element already having a part attribute. * chore: adjust combo-boxes focus outline * Fast commit to switch branches * Modified gitignore * feat: - Removed unused code - Made code reviews * feat: - Made more code reviews * Fast commit to switch branches * Renamed class with a more generic name * Fast commit to switch branches * Made more code reviews * Fast commit to switch branches * Pushed common functions * Fast commit to switch branches * fix: fix AutoComplete events - fix empty value; - always emit the error; - do not validate at each key pressed. * test: add empty and error tests * fix: fix initial empty value * removed unneeded key * fix: allow selecting item identical to the typed value * test: update test * Fast commit to switch branches * test: add address group test * Fast commit to switch branches * test: fix import * feat: show loading icon on auto-complete fields * feat: allow some time before showing the loading icon * chore: add helper text * fix: validate multi-select field * fix: remove deleted address from contacts * Fast commit to switch branches * chore: small fix to remove extra spaces on the first step * - Made code reviews - Improve code and made it more genetic * Made code reviews * FSADT1-928 * Fixed code smell issues * Fixed code smell issues * Create unit test * chore: forcing update * Changed annotation * Renamed file as it had a typo * chore: apply custom directives to unit tests * Fixed some smell issues * test: attempt to fix test on github actions * Made more code reviews * Made more code reviews * chore: adjust Application submitted breakpoints * chore: adjust margins on Application submitted * fix: adjust header buttons breakpoint Import missing variable. * Added more coverage * Beautified CSS file --------- Co-authored-by: Fernando Terra <fernando.terra@encora.com> Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
mamartinezmejia
added a commit
that referenced
this issue
Jan 4, 2024
* fix(FSADT1-1086): Email Address Pattern Found * fix(FSADT1-1086): Email Address Pattern Found - Obfuscated email * Added comments * fix(FSADT1-1086): Email Address Pattern Found - Obfuscated email #2 * no message * no message * no message * Fixing Security Hotspots * fix(FSADT1-1086): Email Address Pattern Found - Obfuscated email #3 * - Upgraded Cypress - Added Cypress test * test: Updated test accordingly * test: Updated test accordingly * Fixed package-lock.json * Downgraded vite as it is not fully supported by Cypress * Downgraded vite as it is not fully supported by Cypress * Rebuilt package-lock.json * chore: reverting cypress version due to conflict * chore: updating deps * - Upgraded Cypress version - Removed unneeded code * Pushed package-json again --------- Co-authored-by: Fernando Terra <79578735+fterra-encora@users.noreply.github.com> Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca>
mamartinezmejia
added a commit
that referenced
this issue
Apr 5, 2024
mamartinezmejia
added a commit
that referenced
this issue
Aug 7, 2024
mamartinezmejia
added a commit
that referenced
this issue
Aug 20, 2024
mamartinezmejia
added a commit
that referenced
this issue
Sep 20, 2024
mamartinezmejia
added a commit
that referenced
this issue
Oct 4, 2024
This was referenced Oct 4, 2024
21 tasks
fterra-encora
added a commit
that referenced
this issue
Oct 17, 2024
* feat(FSADT1-1519): Draft for Create API endpoint for predictive search * Added temporary feature flag for the search functionality * feat(FSADT1-1519): Predictive search endpoint #1 * feat(FSADT1-1519): Predictive search #2 * feat(be:FSADT1-1519): Create API endpoint for predictive search * feat(be:FSADT1-1519): Create API endpoint for predictive search * chore: Added javadocs * Removed unused imports * feat(be:FSADT1-1519): Create API endpoint for predictive search * Refactored code and included full seach * Refactored code to have 1 query only * Added count in the API * feat(fe:FSADT1-1541): Display an error message when the BE is down (#1227) * feat(fe:FSADT1-1521): create the predictive search (#1223) * feat: add search box with predictive search * fix: fix predictive-search stubs * feat: update style of search controls * docs: update interface name * fix: use placeholder instead of label * test: add search test file * feat: navigate to client details * test: implement tests * refactor: move functions to the GlobalValidators * feat: validate autocomplete while typing * feat: validate keywords * test: validate keywords * feat: prevent selection on AutoComplete * feat: open client details in a new tab * chore: update endpoint stub * test: update tests * feat(fe:FSADT1-1541): Display an error message when the BE is down (#1227) * fix: rename event from click to click:option --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * Renamed files * Added missing key * fix(fe:FSADT1-1521): clear the AutoComplete field when preventSelection is true (#1230) * test: fix tests * fix: do not prevent the clearing action * Added stubs for full search * fix: apply the feature flag to the Client search button And remove it from the check of user's authority. * chore: add header x-total-count to stub * feat: add css tag colors from nr-theme * feat: set status tag colors * fix: prevent emitting the full css theme * feat: emit press:enter * fix: prevent emitting press:enter when it's a selection * feat: update full search behavior * feat: prevent search with invalid value * fix: reset error message * fix: remove optional from validations * chore: update stub file * fix: display empty acronyms Also sets column widths * test: check results by index * fix: fix displaying issue on status column Also updates css class names * test: add more tests * fix: allow empty search * test: search with no keywords --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TL;DR
Topics greatly improve the discoverability of repos; please add the short code from the table below to the topics of your repo so that ministries can use GitHub's search to find out what repos belong to them and other visitors can find useful content (and reuse it!).
Why Topic
In short order we'll add our 800th repo. This large number clearly demonstrates the success of using GitHub and our Open Source initiative. This huge success means it's critical that we work to make our content as discoverable as possible. Through discoverability, we promote code reuse across a large decentralized organization like the Government of British Columbia as well as allow ministries to find the repos they own.
What to do
Below is a table of abbreviation a.k.a short codes for each ministry; they're the ones used in all
@gov.bc.caemail addresses. Please add the short codes of the ministry or organization that "owns" this repo as atopic.That's it, you're done!!!
How to use
Once topics are added, you can use them in GitHub's search. For example, enter something like
org:bcgov topic:citzto find all the repos that belong to Citizens' Services. You can refine this search by adding key words specific to a subject you're interested in. To learn more about searching through repos check out GitHub's doc on searching.Pro Tip 🤓
If your org is not in the list below, or the table contains errors, please create an issue here.
While you're doing this, add additional
topicsthat would help someone searching for "something". These can be the language usedjavascriptorR; something likeopendataordatafor data only repos; or any other key words that are useful.Add a meaningful description to your repo. This is hugely valuable to people looking through our repositories.
If your application is live, add the production URL.
Ministry Short Codes
NOTE See an error or omission? Please create an issue here to get it remedied.
The text was updated successfully, but these errors were encountered: