Merge setup-pipeline: trigger pipeline testing #4

MCatherine1994 · 2022-07-07T19:31:41Z

No description provided.

…n pipeline

MCatherine1994 · 2022-07-07T20:01:39Z

DEV deployments have completed successfully!
Backend: https://nrfl-4-backend.apps.silver.devops.gov.bc.ca/
Frontend: https://nrfl-4-frontend.apps.silver.devops.gov.bc.ca/

MCatherine1994 · 2022-07-07T20:06:49Z

Backend coverage report

Coverage after merging setup-pipeline into dev will be

5.92%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
src
app.controller.ts	100%	100%	100%	100%
app.module.ts	0%	0%	100%	0%	1, 15, 15, 17, 17–18, 18, 2–3, 30, 4–5
app.service.ts	100%	100%	100%	100%
main.ts	0%	0%	0%	0%	1, 11–12, 14, 14, 14, 14–15, 2, 20, 22, 28, 3, 30, 30, 30, 30, 30–31, 33, 4, 40, 42, 5, 8
src/core
CoreConstants.ts	0%	100%	100%	0%	1–2
src/deferralcategorycode
deferralCategoryCode.module.ts	0%	100%	100%	0%	1, 12, 2–5
src/deferralcategorycode/controllers
deferralCategoryCode.controller.ts	0%	100%	0%	0%	1, 11–12, 2–3, 7–8
src/deferralcategorycode/entities
deferralCategoryCode.entity.ts	0%	100%	100%	0%	1, 10, 13, 16, 4, 7
src/deferralcategorycode/services
deferralCategoryCode.service.ts	0%	100%	0%	0%	1, 13, 17, 2, 29, 3–4, 9
src/email
email.module.ts	0%	100%	100%	0%	1, 11, 2–4
src/email/controllers
email.controller.ts	0%	100%	0%	0%	1, 12–13, 2–4, 8–9
src/email/model
email.entity.ts	0%	100%	100%	0%	1, 21, 27, 3, 8
src/email/services
email.service.ts	0%	0%	0%	0%	1, 11–12, 15, 2, 23, 25, 25, 28, 3, 33–35, 37, 37–38, 38, 38, 4, 42, 48, 48–49, 55, 57, 57–58, 6, 64, 64, 73, 73, 8, 81, 86, 90, 96
src/spatialfile
spatialFile.module.ts	0%	100%	100%	0%	1, 13, 2–6
src/spatialfile/controllers
spatialFile.controller.ts	0%	100%	0%	0%	1, 12–13, 17–18, 2, 22–23, 3–4, 8–9
src/spatialfile/entities
spatialFile.entity.ts	0%	100%	100%	0%	1, 11, 17, 2, 24, 31, 55
spatialFileCreate.dto.ts	0%	100%	100%	0%	1, 14, 3, 33, 8
src/spatialfile/services
spatialFile.service.ts	0%	0%	0%	0%	1, 11, 15, 2, 21, 25–28, 28, 28, 3, 32, 37, 4, 41, 8

MCatherine1994 · 2022-07-07T20:15:11Z

Your Pull Request code is being promoted! Please follow the link below.
Main Merge Workflow

- Draft of the FE without JSON schema #4

* no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>

* feat(FSADT1-639): adding bcregistry details backend * feature(FSADT1-639): adding loading on frontend * feature(FSADT1-639): adding bc registry params for deployment * feat: updating form to load addresses * chore(deps): update registry.access.redhat.com/ubi8/ubi docker tag to v8.7-1090 * fix(deps): update dependency org.springframework.boot:spring-boot-starter-parent to v3.0.4 * chore(deps): update dependency maven-wrapper to v3.2.0 * chore(deps): update maven all non-major dependencies * fix(deps): update vitest monorepo to ^0.29.0 * chore(deps): update dependency org.apache.maven.plugins:maven-failsafe-plugin to v3 * chore(deps): update dependency org.apache.maven.plugins:maven-surefire-plugin to v3 * chore(deps): update linters * chore(deps): update postgres docker tag to v15 * Frontend improvements (#400) * no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * Frontend improvements (#400) * no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * Frontend improvements (#400) * no message * feat(fe): - First draft of the FE without JSON schema * feat(fe): - Draft of the FE without JSON schema #2 * feat(fe/be): - Draft of the FE without JSON schema #3 - Changed data model * feat(fe/be): - Draft of the FE without JSON schema #4 * feat(fe/be): - Draft of the FE without JSON schema #5 * feat(fe/be): - Draft of the FE without JSON schema #5 - Completed Autocomplete - Renamed some files * feat(fe/be): - Draft of the FE without JSON schema #6 * fix(fe/be): - Fixed some issues in the SQL scripts and the unit test * feat(fe/be): - Draft of the FE without JSON schema #7 - Added missing validation components * Dropped example * fix(fe): - Fixed some issues in the unit test * feat(fe): - Draft of the FE without JSON schema #8 - Improved code and made code reviews * fix: fixing tests * feat(fe): - Cleaned up code - Improved code and made code reviews * feat(fe): - Cleaned up code - Improved code and made code reviews - Changed some names as per naming conventions * no message * feat(be): - Dropped and added some columns * Fixed typo * feat(fe): - Added missing logic to add the incorporation number * fix(be): - Fixed unit tests after recent changes * fix: adding missing field to the database * feat(fe): - Aligned id names to dto keys for validations practicity * feat(fe): - Added the vue mask library * feat(fe): - Removed unneeded column - Added responsiveness in the table - Beautified code * fix(fe): - Fixed some issues in the unit test * fix(fe): - Fixed some issues in the unit test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * Change backend and legacy to matrix format on github action (#404) * chore: Change backend and legacy to matrix format on github action (#404) * fix: fixing class parameter names * chore: updating workflow * fix: fixing workflow var and unifying secrets - moving all secrets to init - fixing variables used on workflow that missed the $ character - renamed the secrets to be a single one - moved vault stage to init step * ci: fixing deploy of init * Add single quotes to Vault vars * Update README.md (#406) * Update README.md * Update README.md * Bump deployer action version * fix: fixing variable with space issue * doc: updating swagger documentation * fix: fixing secrets * fix: reverting version for test --------- Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> Co-authored-by: brunoMarchiEncora <117365587+brunoMarchiEncora@users.noreply.github.com> Co-authored-by: Derek Roberts <derek.roberts@gmail.com>

- Switching to FSA theme - Part #4

…478) * feat(FE:FSADT1-772): adding stub server * feat(FE:FSADT1-772): updating radio to use new component * SonarCloud Frontend config * feat(FE:FSADT1-772): adding text input component * chore: reordering folders * ci: updating frontend sonar config * ci: fixing test command * SonarCloud adjustments * chore: updating files * feat(FE:FSADT1-772): adding new autocomplete component * ci: updating coverage details * chore: updating report config * chore(FE): changing sonar report to clover * fix(FE): fixing coverage report * chore(FE): changing radio button response * chore: fixing bootstrap component events - fixing bootstrap event consumption - updating AutoCompleteInputComponent and TextInputComponent to reflect above changes - updated tests for the above components - updatef form to reflect changes - added new type for the auto complete * feat(FE:FSADT1-772): updating form and components to carbon * chore: updating style - updating style of wizard - updating icons to carbon * chore: updating devcontainer and workspace * chore: removing debug code * feat(FE:FSADT1-785): updating business info * chore: adding type to ForestClientService.ts * chore: updating dtos * chore: updating stubs * chore: updating forms to reflect existing data * chore: updating some global styles * feat: adding new notification component * chore: updating pages * fix: fixing business info screen * fix: fix component initial value * chore: fixing form style * chore: fixing component labels * feat: adding wizard progress indicator component * chore: added bc gov sans font * chore: updating styles * feat(FE:FSADT1-785): adding review page - added review page - added function to navigate between steps * feat(fe): - Changed banner - Changed logo - Added common FSA styles * feat(fe): - Changed icon * chore: adding initial validators * chore: fixing style and adding validation - adding validators - updating validators - fixing some style issues - adding error handlig to all components * chore: stylying multi-select tags * chore: updating validators * chore: adding ignore case to unique validator * feat: adding modal and toast for delete - added modal - added toast notification - added remove address function - added remove contact function * chore: adding provide/inject to modal * feat: add links to progress indicator bar * feat: footer buttons change when review is ok * chore: updating workspace * chore: adding extension suggestion * chore: organize dependencies * chore: organize dependencies * chore: adding submission complete page and router * feat: adding form completion and updating route * chore: updating style * chore: updating modal mechanism to use vueuse * chore: readding vueuse * chore: code formatting * fix: autocomplete fetch when returning to screen * chore: updating to use pictograms * chore: updating toast * chore: changing icon for pictogram * chore: updating validators * feat: adding new inputmask for webcomponents * chore: updating stubs * chore: adding test content to the home page * chore: adding logout and exit in case of error * chore: updated MainHeader to carbon * chore: updating progress and style - updating progress indicator to add disabled state - updating styles to apply to shadow dom - updated business info to notify on errors - added inputmask definition helper - updated main to use non-deprecated types * fix: fixing file name * fix: fixing progress indicator * feat: adding mail message when duplicated * fix: removing vault due to inconsistency (#490) * chore(deps): update maven all non-major dependencies (#488) * chore(deps): update testcontainers-java monorepo to v1.18.3 * fix(deps): update dependency vite to v4.3.9 [security] * chore(deps): update maven all non-major dependencies * fix: removing vault due to inconsistency --------- Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com> Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * chore: clip digests (#484) * chore: clip digests * chore: removing unwanted files --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * FSADT1-749 (#482) * FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * fix(be): - SonarCloud improvements. - Related to FSADT1-749 * chore: Refactor and improve existing unit tests * chore: Improve existing unit tests * Beautified code * Revert "chore: Improve existing unit tests" This reverts commit 1b2aa73. * no message * Revert "no message" This reverts commit 91115b5. * chore: updating tests * chore: updating tests * chore: updating tests * fix(be): - Fixed code smell issue * fix: updating ches auth procedure * fix: fixing ches mail test --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * chore: updating codeowners (#492) Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca> * feat(BE:FSADT-745): updating mail template (#491) * no message * no message * FSADT1794 * feat:(BE:FSADT1-745): changing mail template contents * chore: removing unused files * chore: updating templates * chore: updating templates --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * feat(be): (#493) - Made a minor change in the DB as per suggested by the DBAs (FSADT1-796) * feat(BE:FSADT1-794): updating content (#494) * no message * no message * FSADT1794 * feat:(BE:FSADT1-745): changing mail template contents * chore: removing unused files * chore: updating templates * chore: updating templates * fix(be): - Fixed code smells * feat(be): - Updated templates as per requested by Andrew (FSADT1-794) --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * (FSADT1-796) Changes in the DB (#496) * feat(be): - Made a minor change in the DB as per suggested by the DBAs (FSADT1-796) * feat(be): - Added new column to store the unique identifier assigned to a contact --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * chore(deps): update dependency c8 to v8 (#499) Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com> * chore(deps): update dependency jsdom to v22 (#500) Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com> Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com> * chore: updating package lock * chore: adding username * fix: fixing package lock * fix: fixing build - fixing build by removing unused dependencies - removing unused files * fix: adding vue tsc * chore: updating dockerfile * docs: updating extensions * fix: fixing invisible HR * chore: removing bootstrap * ci: fixing build * ci: fixing deployment order * chore: cleaning up the backend code * chore: adding submission info * chore: removing phone mask to check for validity * chore: trimming postal code * chore(temp): adding temporary presentation mail * feat: adding initial loading info to ac and fetcher * chore: adding data conversion - fixing legal and client type - adding data conversion for client type - using conversion * ci: adding platform for oracle db * chore: overwriting route * fix: fixing replace * fix: fixing BE build * fix: fixing BcRegistryExceptionMessageDto * fix: set state to invalid when business name input gets changed * chore: renaming dto and enabling to reflection * chore: setting content to 50% of screen * chore: adding margin to header * chore: fixing tab header space * chore: adding scroll to top * fix: reset data after form submission * fix(deps): update vitest monorepo to ^0.32.2 * chore: updating deploy check * fix: adding new CORS header keys * fix: fixing native build * fix: adding cors header manually * fix: adding new CORS header keys * ci: increasing resource due to constant restarts * chore: fixing dto property name * chore: adding location contact association * ci: fixing cypress test * ci: changing CHES to prod * fix(fe): - Fixed business name from proper keycloak key * chore: adding error log to ches * chore: adding ChesMailRequest to reflection * chore: adding ChesMailResponse to reflection * fix(fe): - Fixed typo * feat(fe): - Removed unused constants * chore: fixing unregistered client type * feat: adding global validator for submission * chore: updating stubs * chore: adding on-load validation check this is to force it to check for validity when changing screens, specially for when you move back to a tab * chore: cleanung up app.vue * chore: updating recommended extensions * chore: updating gitignore * chore: renaming components to short imports * chore: adding import back * chore(fe): - Made code reviews and beautified code * chore: changing colors * chore: removing field from buttons * chore: removing form reset * chore: updating autocomplete and textinput components * feat: address autocomplete stubs * feat(FE:FSADT1-812): add autocomplete to frontend * feat(BE:FSADT1-812): updating address backend api * fix(FE:FSADT1-805): fixing country not selected * chore: fixing loading image during api loading * fix: fixing dropdown updates * fix: fixing reset on province data after changes * chore: adding delay to some stub apis * chore: removing format on paste * feat(FE:FSADT1-812): adding loading on details loading and global error * feat: adding canada post api to deployment * chore: fire update:selected-value with undefined When the user changes the input value manually after a selection had been made. * test: emits update:selected-value * test: emit update:selected-value with new value * fix: remove duplicated error handler * test: fix element finding * test: fix expected text in the header * chore: moving composables to its own folder - aligning the composable functions we have to the standard vue folder structure - removing colors.ts as it wasn't being used * fix: fixing refactor issues * ci: fixing frontend build * chore: cleaning imports * chore: increasing coverage * chore: fixing code smell on backend * chore: fixing code smell on backend * chore: fixing sonar bugs * fix: removing unused components * fix(security): mitigating a few frontend security issues * chore: updating workspace and extensions * fix(codesmell): fixing codesmell * feat(fe): - FSADT1-811: Added logout fn * ci: adding vite node env as part of deployment * chore: updating lint and adding reformatted code * chore: simplifying keycloak loading and passing - refactored main.ts and App.vue to simplofy keyckload data - updated form page to consume the keycloak instance * fix(typescript:S905): fixing logout issue * fix: trying to disable sonar rules * test: updating coverage configuration * feat(fe): - Switching to FSA theme - Part #1 * fix: - Changed from px to rem - Added new overrides * test: updating coverage configuration * chore: adding lint dependencies * chore: updating validators and function signature * test: adding some tests * fix: - Added changes from the FSA theme repo temporarly * fix: fixing code smells * test: ignoring more files * chore: fixing code smell and adding new ignores * chore: refactoring files * test: ignoring files * chore: removing unused components * chore: refactoring component location * chore: removing default header * test: removing test * test: fixing existing tests warn messages * test: adding test * test: adding useFetch test * chore: updating components * feat(fe): - Switching to FSA theme - Part #2 * test: testing App.vue * fix: fixing dropdown initial value * chore: refactoring NoteComponent * chore: updating App test to mock header * chore: updating useFetch test * test: adding few more tests * test: adding multi select test * chore: removing main from coverage * ci: adding env configuration * feat(fe): - Switching to FSA theme - Part #3 * chore: fixing code smell * chore: updating gitignore * chore: updating vite configuration * test: adding/updating test dependencies * test(cypress): updating cypress configuration * test: adding HomePage component test * docs: updating gitignore * chore: updating/removing old cypress files * ci: updating frontend test configuration * test: updating some tests and test configuration * test: updating tests * chore: tweaking coverage results * chore: fixing bug * feat(FE:FSADT1-814): Vertical wizard (breadcrumb) (#515) * chore: display equal width for wizard steps And display ellipsis when text doesn't fit. * feat: display wizard steps vertically * test: display steps either vertically or horizontally * test: add more examples * style: format feature file * style: remove unused variable * chore: replace px units with rem * ci: fixing lcov report issue * feat(fe): - Switching to FSA theme - Part #4 * chore: removing dependency * chore: removing rm * chore: fixing nyc --------- Co-authored-by: Derek Roberts <derek.roberts@gmail.com> Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Fernando Terra <fernando.terra@encora.com> Co-authored-by: BCGov-NR Renovate Bot <42219260+bcgov-renovate@users.noreply.github.com> Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> Co-authored-by: Fernando Terra <79578735+fterra-encora@users.noreply.github.com>

* fix: fixing progress state when error * fix: fixing error notification Fixing error notification below progress indication. * fix: fixing dropdown * fix: fixing multi select * chore: updating stubs to add more addresses * fix: fixing dropdown not changing when selection change * feat: add formErrors variable * chore: redoing css changes - Part #1 * feat: display address extra errors * feat: move extra errors to the error component * chore: redoing css changes - Part #2 * feat: replace formErrors argument with notification approach * feat: scroll to new contact * feat: add callback argument to useFocus * feat: make the bindings to create and scroll to new contact * chore: minor adjusments on useFocus * chore: redoing css changes - Part #3 * chore: redoing css changes - Part #4 * test: test the validation function and the error component * fix: update contactType value on select * test: ignore already valid location * test: remove outdated test * feat: add parameter for the shadow directive * feat: display progress indicator vertically Also adds some changes for displaying it horizontally. * FSADT1-868: Allowed special characters. Done olnly in the Frontend as the Backend was already allowing special charactes. * test: add getMany command * test: add progress indicator tests * fixed inline notification colors * Removed wrong style * Added property needed * feat: show logout modal * refactor: unify code for the logout button in different sizes * feat: show help modal * feat: use media query instead of outerWidth to determine screen size * Removed class that was causing issues with the logout button * Revert "Removed class that was causing issues with the logout button" This reverts commit 827e496. * Fixed logout button * feat: adjust header buttons * Fixed mask issue with the postal code * Renamed some files before refactoring code * no message * Made code reviews * chore: remove console.log * fix: prevent an older request from overwriting the results * Made requiered changes * Removed repeatead code * Removed unneeded setting * fix: do not always block response from older request It should be allowed when no newer request was yet responded. * chore: use simple counter to generate requestId * fix: init fetching * test: fix test * Fixed file * Added javadoc comment as per requested by SonarCloud * docs: improve comment * feat: adjust header logo and buttons * feat: adjust header spaces and breakpoints * chore: use date milliseconds as id * fix: fix build issue * fix: prevent error in the workflow * fix: attempt to fix tests in the workflow * fix: remove package from optimizeDeps As an attempt to prevent error in the workflow. * refactor: requested changes from review * Refactored code - Part #1 * Made code reviews * Formatted and beautified code * style: small changes to code style * chore: fix code linter * Refactored code - Part #1.1 * fix: Fixed sonarcloud security hotspot issue * fix: Fixed security hotspot * Refactored code - Part #2 * Refactored code - Part #2.1 * fix: fix header small screen * fix: attempt to fix side effect in the workflow * chore: submitting small changes * fix(FSADT1-884): fixing steps being enable - adjusted the steps to be disable by default - only enable if valid and only for the next step * chore: sorting import * fix(FSADT1-887): fixing typo on step 4 * fix(FSADT1-889): fixing font style * fix: Fixed security hotspot and improved wording * fix: Fixed security hotspot * fix(FSADT1-888): fixing spacing between radio buttons * Trying a different approach to solve the security hotspot issue * fix(FSADT1-892): fixing submission page * Trying a different approach to solve the security hotspot issue #2 * fix(FSADT1-894): fixing field spacing and width * fix(FSADT1-891): fixing modal spacing * fix(FSADT1-889): fixing notification body content * fix(FSADT1-890): fixing component alignment * fix: Fixed security hotspot * fix: Fixed security hotspot * Made code reviews * Removed unused variable * Refactored code and made code reviews * feat: adjust margins * fix(FSADT1-884): removing navigation link * Made code reviews * fix: header height * chore: replace mock e-mail from .local to .com * fix: do not pre-validate current step * feat: replace margin with padding * FSADT1-899: Removed unneeded validation * ci: updating trivy to fix issues * no message * no message * Tried to skip SonarCloud validation * Skipped SonarCloud validation * chore: adding us address stub data * fix(FSADT1-884): fixing subtitle style * fix: autocomplete after changing country * fix: fix subtitle style for vertical progress indicator * fis(FSADT1-894): fixing style for inline and text * Made code reviews * FSADT1-879 * - Made code reviews - Removed unused code * Made code reviews * Made code reviews * Made improvement * feat: clear text displayed on combo-box * fix: clear text displayed on combo-box Without using any private properties from the component. * refactor: move iteration props * fix: fix link to bceid * chore: remove unused import * fix: remove placeholders on country and province * fix: fix casing for Business information * fix: fix doc coment closing For some reason this was messing the code displayed in the Chrome browser sources. * fix: conditions used on postalCode validations * chore: fix VS Code resolution for source and test files By fixing the test configuration and eliminating a conflict with the app one. * test: use a new query command after a click Since it's unsafe to chain after a click. * test: force click button * fix: prevent completing business step with invalid data * fix: prevent fetching for name "undefined" * test: wait before clicking the option * Made a minor change for internal emails after a conversation with Andrew. * style: add semi-colon as requested after review * style: add the dollar signal to all conditions * feat: turn the dollar signal required * Made code reviews * Made more code reviews * Made this to prevent perisisting information mutliple times * test: wait for the option's inner element to become visible * fix: emit error always for text-input Instead of only when the error changes. * fix: update error status on Address step text fields So to be able to properly make it valid later when it gets resolved. * fix: update Street address empty status properly * test: emit empty true when contents is empty * docs: refer specific Jira issue * fix: - Renamed variable and added an new property to make it more generic - Beautified code * fix: - Renamed variable and added an new property in test file * fix: Made code reviews and removed unneeded prop I added * fix: update error status on Contacts step text fields So to be able to properly make it valid later when it gets resolved. * test: emit valid events properly * no message * fix: - Renamed variable with a proper name - Made code reviews * docs: improve comment * docs: improve comment * fix: synchronize dropdown value * fix: get country validation * fix: validate after changed from outside * test: define some tests to be implemented * test: province gets cleared * docs: add issue references * test: revalidates when changed from outside Also fixes another test. * Fast commit to switch branches * fix: validate the item code instead of its name * test: update tests * fix: remove meaningless tag * fix: do not display field as invalid When the field is empty and user didn't have a chance to add its value yet. For example, when it gets auto-changed as a result of changing another field. * Fast commit to switch branches * fix: Made code reviews and added birth date field * fix: Fixed logo for small screens * test: do not emit error in specific situation * feat: use variable to tell if selection was a user event * test: update tests * chore: use variable to tell if the change was a user event * test: update test * feat: add tooltip to button Next * fix: proceed applying part to next level Regardless of current element already having a part attribute. * chore: adjust combo-boxes focus outline * Fast commit to switch branches * Modified gitignore * feat: - Removed unused code - Made code reviews * feat: - Made more code reviews * Fast commit to switch branches * Renamed class with a more generic name * Fast commit to switch branches * Made more code reviews * Fast commit to switch branches * Pushed common functions * Fast commit to switch branches * fix: fix AutoComplete events - fix empty value; - always emit the error; - do not validate at each key pressed. * test: add empty and error tests * fix: fix initial empty value * removed unneeded key * fix: allow selecting item identical to the typed value * test: update test * Fast commit to switch branches * test: add address group test * Fast commit to switch branches * test: fix import * feat: show loading icon on auto-complete fields * feat: allow some time before showing the loading icon * chore: add helper text * fix: validate multi-select field * fix: remove deleted address from contacts * Fast commit to switch branches * chore: small fix to remove extra spaces on the first step * - Made code reviews - Improve code and made it more genetic * Made code reviews * FSADT1-928 * Fixed code smell issues * Fixed code smell issues * Create unit test * chore: forcing update * Changed annotation * Renamed file as it had a typo * chore: apply custom directives to unit tests * Fixed some smell issues * test: attempt to fix test on github actions * Made more code reviews * Made more code reviews * chore: adjust Application submitted breakpoints * chore: adjust margins on Application submitted * fix: adjust header buttons breakpoint Import missing variable. * Added more coverage * Beautified CSS file --------- Co-authored-by: Fernando Terra <fernando.terra@encora.com> Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>

feat/frontend: trigger pipeline testing

9bd13d6

MCatherine1994 had a problem deploying to dev July 7, 2022 19:38 Failure

fix: fix frontend test; remove backend comment; added token to pr ope…

3b4c7d3

…n pipeline

MCatherine1994 had a problem deploying to dev July 7, 2022 19:43 Failure

fix/pipeline: disabled email service variable

3ccc911

MCatherine1994 had a problem deploying to dev July 7, 2022 19:50 Failure

fix/pipeline: fix comment error

476ba42

MCatherine1994 temporarily deployed to dev July 7, 2022 19:58 Inactive

fix/frontend: update project title

dacb621

MCatherine1994 temporarily deployed to dev July 7, 2022 20:10 Inactive

MCatherine1994 merged commit 75c6cc5 into dev Jul 7, 2022

MCatherine1994 temporarily deployed to dev July 7, 2022 20:15 Inactive

MCatherine1994 deleted the setup-pipeline branch July 8, 2022 22:36

mamartinezmejia added a commit that referenced this pull request Mar 2, 2023

feat(fe/be):

324d16a

- Draft of the FE without JSON schema #4

This was referenced Mar 22, 2023

feat(FSADT1-355): removing orgbook code and replacing with bcregistry #417

Merged

fix(fe): fixing config.js mapping #418

Merged

mamartinezmejia added a commit that referenced this pull request Jul 11, 2023

feat(fe):

d165303

- Switching to FSA theme - Part #4

mamartinezmejia added a commit that referenced this pull request Sep 14, 2023

chore: redoing css changes - Part #4

ffdaab4

paulushcgcj pushed a commit that referenced this pull request Oct 10, 2023

chore: redoing css changes - Part #4

6b5b47f

github-actions bot mentioned this pull request Oct 23, 2023

chore(deps): update dependency @cypress/webpack-preprocessor to v6 #579

Merged

1 task

mamartinezmejia added a commit that referenced this pull request Jan 31, 2024

Attempt #4

75e60b9

mamartinezmejia added a commit that referenced this pull request Apr 7, 2024

feat(be:FSADT1-1277): Part #4

42aeacf

github-actions bot mentioned this pull request Apr 8, 2024

feat(be:FSADT1-1277): Strict Input validation on backend #910

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge setup-pipeline: trigger pipeline testing #4

Merge setup-pipeline: trigger pipeline testing #4

MCatherine1994 commented Jul 7, 2022

MCatherine1994 commented Jul 7, 2022

MCatherine1994 commented Jul 7, 2022

MCatherine1994 commented Jul 7, 2022

Merge setup-pipeline: trigger pipeline testing #4

Merge setup-pipeline: trigger pipeline testing #4

Conversation

MCatherine1994 commented Jul 7, 2022

MCatherine1994 commented Jul 7, 2022

MCatherine1994 commented Jul 7, 2022

Backend coverage report

MCatherine1994 commented Jul 7, 2022