Skip to content

Commit

Permalink
feat(FE:FSADT1-785): updating frontend to new components and wizard (#…
Browse files Browse the repository at this point in the history
…478)

* feat(FE:FSADT1-772): adding stub server

* feat(FE:FSADT1-772): updating radio to use new component

* SonarCloud Frontend config

* feat(FE:FSADT1-772): adding text input component

* chore: reordering folders

* ci: updating frontend sonar config

* ci: fixing test command

* SonarCloud adjustments

* chore: updating files

* feat(FE:FSADT1-772): adding new autocomplete component

* ci: updating coverage details

* chore: updating report config

* chore(FE): changing sonar report to clover

* fix(FE): fixing coverage report

* chore(FE): changing radio button response

* chore: fixing bootstrap component events

- fixing bootstrap event consumption
- updating AutoCompleteInputComponent and TextInputComponent to reflect above changes
- updated tests for the above components
- updatef form to reflect changes
- added new type for the auto complete

* feat(FE:FSADT1-772): updating form and components to carbon

* chore: updating style

- updating style of wizard
- updating icons to carbon

* chore: updating devcontainer and workspace

* chore: removing debug code

* feat(FE:FSADT1-785): updating business info

* chore: adding type to ForestClientService.ts

* chore: updating dtos

* chore: updating stubs

* chore: updating forms to reflect existing data

* chore: updating some global styles

* feat: adding new notification component

* chore: updating pages

* fix: fixing business info screen

* fix: fix component initial value

* chore: fixing form style

* chore: fixing component labels

* feat: adding wizard progress indicator component

* chore: added bc gov sans font

* chore: updating styles

* feat(FE:FSADT1-785): adding review page

- added review page
- added function to navigate between steps

* feat(fe):
- Changed banner
- Changed logo
- Added common FSA styles

* feat(fe):
- Changed icon

* chore: adding initial validators

* chore: fixing style and adding validation

- adding validators
- updating validators
- fixing some style issues
- adding error handlig to all components

* chore: stylying multi-select tags

* chore: updating validators

* chore: adding ignore case to unique validator

* feat: adding modal and toast for delete

- added modal
- added toast notification
- added remove address function
- added remove contact function

* chore: adding provide/inject to modal

* feat: add links to progress indicator bar

* feat: footer buttons change when review is ok

* chore: updating workspace

* chore: adding extension suggestion

* chore: organize dependencies

* chore: organize dependencies

* chore: adding submission complete page and router

* feat: adding form completion and updating route

* chore: updating style

* chore: updating modal mechanism to use vueuse

* chore: readding vueuse

* chore: code formatting

* fix: autocomplete fetch when returning to screen

* chore: updating to use pictograms

* chore: updating toast

* chore: changing icon for pictogram

* chore: updating validators

* feat: adding new inputmask for webcomponents

* chore: updating stubs

* chore: adding test content to the home page

* chore: adding logout and exit in case of error

* chore: updated MainHeader to carbon

* chore: updating progress and style

- updating progress indicator to add disabled state
- updating styles to apply to shadow dom
- updated business info to notify on errors
- added inputmask definition helper
- updated main to use non-deprecated types

* fix: fixing file name

* fix: fixing progress indicator

* feat: adding mail message when duplicated

* fix: removing vault due to inconsistency (#490)

* chore(deps): update maven all non-major dependencies (#488)

* chore(deps): update testcontainers-java monorepo to v1.18.3

* fix(deps): update dependency vite to v4.3.9 [security]

* chore(deps): update maven all non-major dependencies

* fix: removing vault due to inconsistency

---------

Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>

* chore: clip digests (#484)

* chore: clip digests

* chore: removing unwanted files

---------

Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>

* FSADT1-749 (#482)

* FSADT1-749

* fix(be):
- SonarCloud improvements.
- Related to FSADT1-749

* fix(be):
- SonarCloud improvements.
- Related to FSADT1-749

* fix(be):
- SonarCloud improvements.
- Related to FSADT1-749

* chore: Refactor and improve existing unit tests

* chore: Improve existing unit tests

* Beautified code

* Revert "chore: Improve existing unit tests"

This reverts commit 1b2aa73.

* no message

* Revert "no message"

This reverts commit 91115b5.

* chore: updating tests

* chore: updating tests

* chore: updating tests

* fix(be):
- Fixed code smell issue

* fix: updating ches auth procedure

* fix: fixing ches mail test

---------

Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>

* chore: updating codeowners (#492)

Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca>

* feat(BE:FSADT-745): updating mail template (#491)

* no message

* no message

* FSADT1794

* feat:(BE:FSADT1-745): changing mail template contents

* chore: removing unused files

* chore: updating templates

* chore: updating templates

---------

Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca>
Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>

* feat(be): (#493)

- Made a minor change in the DB as per suggested by the DBAs (FSADT1-796)

* feat(BE:FSADT1-794): updating content (#494)

* no message

* no message

* FSADT1794

* feat:(BE:FSADT1-745): changing mail template contents

* chore: removing unused files

* chore: updating templates

* chore: updating templates

* fix(be):
- Fixed code smells

* feat(be):
- Updated templates as per requested by Andrew (FSADT1-794)

---------

Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca>
Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>

* (FSADT1-796) Changes in the DB (#496)

* feat(be):
- Made a minor change in the DB as per suggested by the DBAs (FSADT1-796)

* feat(be):
- Added new column to store the unique identifier assigned to a contact

---------

Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>

* chore(deps): update dependency c8 to v8 (#499)

Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>

* chore(deps): update dependency jsdom to v22 (#500)

Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@encora.com>

* chore: updating package lock

* chore: adding username

* fix: fixing package lock

* fix: fixing build

- fixing build by removing unused dependencies
- removing unused files

* fix: adding vue tsc

* chore: updating dockerfile

* docs: updating extensions

* fix: fixing invisible HR

* chore: removing bootstrap

* ci: fixing build

* ci: fixing deployment order

* chore: cleaning up the backend code

* chore: adding submission info

* chore: removing phone mask to check for validity

* chore: trimming postal code

* chore(temp): adding temporary presentation mail

* feat: adding initial loading info to ac and fetcher

* chore: adding data conversion

- fixing legal and client type
- adding data conversion for client type
- using conversion

* ci: adding platform for oracle db

* chore: overwriting route

* fix: fixing replace

* fix: fixing BE build

* fix: fixing BcRegistryExceptionMessageDto

* fix: set state to invalid when business name input gets changed

* chore: renaming dto and enabling to reflection

* chore: setting content to 50% of screen

* chore: adding margin to header

* chore: fixing tab header space

* chore: adding scroll to top

* fix: reset data after form submission

* fix(deps): update vitest monorepo to ^0.32.2

* chore: updating deploy check

* fix: adding new CORS header keys

* fix: fixing native build

* fix: adding cors header manually

* fix: adding new CORS header keys

* ci: increasing resource due to constant restarts

* chore: fixing dto property name

* chore: adding location contact association

* ci: fixing cypress test

* ci: changing CHES to prod

* fix(fe):
- Fixed business name from proper keycloak key

* chore: adding error log to ches

* chore: adding ChesMailRequest to reflection

* chore: adding ChesMailResponse to reflection

* fix(fe):
- Fixed typo

* feat(fe):
- Removed unused constants

* chore: fixing unregistered client type

* feat: adding global validator for submission

* chore: updating stubs

* chore: adding on-load validation check

this is to force it to check for validity when changing screens, specially for when you move back to a tab

* chore: cleanung up app.vue

* chore: updating recommended extensions

* chore: updating gitignore

* chore: renaming components to short imports

* chore: adding import back

* chore(fe):
- Made code reviews and beautified code

* chore: changing colors

* chore: removing field from buttons

* chore: removing form reset

* chore: updating autocomplete and textinput components

* feat: address autocomplete stubs

* feat(FE:FSADT1-812): add autocomplete to frontend

* feat(BE:FSADT1-812): updating address backend api

* fix(FE:FSADT1-805): fixing country not selected

* chore: fixing loading image during api loading

* fix: fixing dropdown updates

* fix: fixing reset on province data after changes

* chore: adding delay to some stub apis

* chore: removing format on paste

* feat(FE:FSADT1-812): adding loading on details loading and global error

* feat: adding canada post api to deployment

* chore: fire update:selected-value with undefined

When the user changes the input value manually after a selection had
been made.

* test: emits update:selected-value

* test: emit update:selected-value with new value

* fix: remove duplicated error handler

* test: fix element finding

* test: fix expected text in the header

* chore: moving composables to its own folder

- aligning the composable functions we have to the standard vue folder structure
- removing colors.ts as it wasn't being used

* fix: fixing refactor issues

* ci: fixing frontend build

* chore: cleaning imports

* chore: increasing coverage

* chore: fixing code smell on backend

* chore: fixing code smell on backend

* chore: fixing sonar bugs

* fix: removing unused components

* fix(security): mitigating a few frontend security issues

* chore: updating workspace and extensions

* fix(codesmell): fixing codesmell

* feat(fe):
- FSADT1-811: Added logout fn

* ci: adding vite node env as part of deployment

* chore: updating lint and adding reformatted code

* chore: simplifying keycloak loading and passing

- refactored main.ts and App.vue to simplofy keyckload data
- updated form page to consume the keycloak instance

* fix(typescript:S905): fixing logout issue

* fix: trying to disable sonar rules

* test: updating coverage configuration

* feat(fe):
- Switching to FSA theme - Part #1

* fix:
- Changed from px to rem
- Added new overrides

* test: updating coverage configuration

* chore: adding lint dependencies

* chore: updating validators and function signature

* test: adding some tests

* fix:
- Added changes from the FSA theme repo temporarly

* fix: fixing code smells

* test: ignoring more files

* chore: fixing code smell and adding new ignores

* chore: refactoring files

* test: ignoring files

* chore: removing unused components

* chore: refactoring component location

* chore: removing default header

* test: removing test

* test: fixing existing tests warn messages

* test: adding test

* test: adding useFetch test

* chore: updating components

* feat(fe):
- Switching to FSA theme - Part #2

* test: testing App.vue

* fix: fixing dropdown initial value

* chore: refactoring NoteComponent

* chore: updating App test to mock header

* chore: updating useFetch test

* test: adding few more tests

* test: adding multi select test

* chore: removing main from coverage

* ci: adding env configuration

* feat(fe):
- Switching to FSA theme - Part #3

* chore: fixing code smell

* chore: updating gitignore

* chore: updating vite configuration

* test: adding/updating test dependencies

* test(cypress): updating cypress configuration

* test: adding HomePage component test

* docs: updating gitignore

* chore: updating/removing old cypress files

* ci: updating frontend test configuration

* test: updating some tests and test configuration

* test: updating tests

* chore: tweaking coverage results

* chore: fixing bug

* feat(FE:FSADT1-814): Vertical wizard (breadcrumb) (#515)

* chore: display equal width for wizard steps

And display ellipsis when text doesn't fit.

* feat: display wizard steps vertically

* test: display steps either vertically or horizontally

* test: add more examples

* style: format feature file

* style: remove unused variable

* chore: replace px units with rem

* ci: fixing lcov report issue

* feat(fe):
- Switching to FSA theme - Part #4

* chore: removing dependency

* chore: removing rm

* chore: fixing nyc

---------

Co-authored-by: Derek Roberts <derek.roberts@gmail.com>
Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca>
Co-authored-by: Fernando Terra <fernando.terra@encora.com>
Co-authored-by: BCGov-NR Renovate Bot <42219260+bcgov-renovate@users.noreply.github.com>
Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com>
Co-authored-by: Fernando Terra <79578735+fterra-encora@users.noreply.github.com>
  • Loading branch information
8 people authored Jul 11, 2023
1 parent 98f4f28 commit 828ac25
Show file tree
Hide file tree
Showing 158 changed files with 17,196 additions and 13,528 deletions.
16 changes: 13 additions & 3 deletions .github/workflows/merge-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,22 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: bcgov-nr/action-test-and-analyse@v0.0.1
env:
VITE_BACKEND_URL: http://localhost:3000
VITE_FRONTEND_URL: http://localhost:8080
VITE_KEYCLOAK_URL:
VITE_KEYCLOAK_CLIENT_ID: 1234
VITE_NODE_ENV:
with:
commands: |
npm ci
npm run test
npm run coverage
dir: frontend
sonar_args: >
-Dsonar.exclusions=**/coverage/**,**/examples/**,**/pages/**
-Dsonar.javascript.lcov.reportPaths=coverage/lcov.info
-Dsonar.exclusions=**/coverage/**/*,**/dist/**/*,**/tests/**/*,**/public/**/*,**/node_modules/**,.eslintrc.cjs,.eslintrc.js,components.d.ts,env.d.ts,src/routes.ts,src/shims-vue.d.ts,vite.config.ts,**/*Dto.ts,src/CoreConstants.ts,src/main.ts
-Dsonar.organization=bcgov-sonarcloud
-Dsonar.projectKey=forest-client-frontend
-Dsonar.tests=src/tests
sonar_project_token: ${{ secrets.SONAR_TOKEN_FRONTEND }}

codeql:
Expand Down Expand Up @@ -164,6 +170,7 @@ jobs:
-p BCREGISTRY_ACCOUNT='${{ secrets.BCREGISTRY_ACCOUNT }}'
-p CHES_CLIENT_ID=${{ secrets.CHES_CLIENT_ID }}
-p CHES_CLIENT_SECRET=${{ secrets.CHES_CLIENT_SECRET }}
-p ADDRESS_COMPLETE_KEY=${{ secrets.ADDRESS_COMPLETE_KEY }}

- name: Conventional Changelog Update
uses: TriPSs/conventional-changelog-action@v3
Expand Down Expand Up @@ -258,6 +265,7 @@ jobs:
-p PROMOTE=${{ github.repository }}/frontend:${{ env.ZONE }}
-p VITE_KEYCLOAK_URL=https://test.loginproxy.gov.bc.ca/auth
-p VITE_KEYCLOAK_CLIENT_ID=${{ secrets.KEYCLOAK_CLIENT_ID }}
-p VITE_NODE_ENV=openshift-${{ env.ZONE }}

- name: Deploy Processor
uses: bcgov-nr/action-deployer-openshift@v1.0.2
Expand Down Expand Up @@ -320,6 +328,7 @@ jobs:
-p BCREGISTRY_ACCOUNT='${{ secrets.BCREGISTRY_ACCOUNT }}'
-p CHES_CLIENT_ID=${{ secrets.CHES_CLIENT_ID }}
-p CHES_CLIENT_SECRET=${{ secrets.CHES_CLIENT_SECRET }}
-p ADDRESS_COMPLETE_KEY=${{ secrets.ADDRESS_COMPLETE_KEY }}

prod-deploy:
name: PROD Deployment
Expand Down Expand Up @@ -406,3 +415,4 @@ jobs:
-p PROMOTE=${{ github.repository }}/frontend:${{ env.PREV }}
-p VITE_KEYCLOAK_URL=https://loginproxy.gov.bc.ca/auth
-p VITE_KEYCLOAK_CLIENT_ID=${{ secrets.KEYCLOAK_CLIENT_ID }}
-p VITE_NODE_ENV=openshift-${{ env.ZONE }}
10 changes: 7 additions & 3 deletions .github/workflows/pr-open.yml
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ jobs:
-p BCREGISTRY_ACCOUNT=${{ secrets.BCREGISTRY_ACCOUNT }}
-p CHES_CLIENT_ID=${{ secrets.CHES_CLIENT_ID }}
-p CHES_CLIENT_SECRET=${{ secrets.CHES_CLIENT_SECRET }}
-p ADDRESS_COMPLETE_KEY=${{ secrets.ADDRESS_COMPLETE_KEY }}

deploy-database:
name: Deploy Database
Expand Down Expand Up @@ -237,8 +238,8 @@ jobs:
parameters:
-p ZONE=${{ github.event.number }} -p NAME=${{ github.event.repository.name }}
-p PROMOTE=${{ github.repository }}/backend:${{ github.event.number }}
-p CHES_TOKEN_URL='https://dev.loginproxy.gov.bc.ca/auth/realms/comsvcauth/protocol/openid-connect/token'
-p CHES_API_URL='https://ches-dev.api.gov.bc.ca/api/v1'
-p CHES_TOKEN_URL='https://loginproxy.gov.bc.ca/auth/realms/comsvcauth/protocol/openid-connect/token'
-p CHES_API_URL='https://ches.api.gov.bc.ca/api/v1/email'
-p BCREGISTRY_URI='https://bcregistry-prod.apigee.net'
- name: Deploy Processor
uses: bcgov-nr/action-deployer-openshift@v1.0.3
Expand Down Expand Up @@ -270,6 +271,8 @@ jobs:
needs:
- deploy-init
environment: dev
env:
ZONE: dev
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v3
Expand All @@ -284,13 +287,14 @@ jobs:
parameters:
-p ZONE=${{ github.event.number }} -p NAME=${{ github.event.repository.name }}
-p PROMOTE=${{ github.repository }}/frontend:${{ github.event.number }}
-p VITE_NODE_ENV=openshift-dev
-p VITE_NODE_ENV=openshift-${{ env.ZONE }}

cypress-run:
name: "User flow test"
runs-on: ubuntu-22.04
needs:
- deploy-frontend
- deploy-backend
environment: dev
env:
DOMAIN: apps.silver.devops.gov.bc.ca
Expand Down
12 changes: 9 additions & 3 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,16 +117,22 @@ jobs:
runs-on: ubuntu-22.04
steps:
- uses: bcgov-nr/action-test-and-analyse@v0.0.1
env:
VITE_BACKEND_URL: http://localhost:3000
VITE_FRONTEND_URL: http://localhost:8080
VITE_KEYCLOAK_URL:
VITE_KEYCLOAK_CLIENT_ID: 1234
VITE_NODE_ENV: openshift-dev
with:
commands: |
npm ci
npm run test
npm run coverage
ls coverage/lcov.info
dir: frontend
sonar_args: >
-Dsonar.exclusions=**/coverage/**,**/examples/**,**/pages/**
-Dsonar.javascript.lcov.reportPaths=coverage/lcov.info
-Dsonar.organization=bcgov-sonarcloud
-Dsonar.projectKey=forest-client-frontend
-Dsonar.tests=src/tests
sonar_project_token: ${{ secrets.SONAR_TOKEN_FRONTEND }}

trivy:
Expand Down
25 changes: 24 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ coverage

# nyc test coverage
.nyc_output
.nyc_report
.vite_report

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt
Expand Down Expand Up @@ -427,6 +429,8 @@ frontend/*.lcov

# nyc test coverage
frontend/.nyc_output
frontend/.nyc_report
frontend/.vite_report

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
frontend/.grunt
Expand Down Expand Up @@ -546,4 +550,23 @@ frontend/yarn-error.log

# End of https://www.toptal.com/developers/gitignore/api/vue,vuejs,node

frontend/nr-forest-client-report.*
frontend/nr-forest-client-report.*
.DS_Store

cypress/results/*
cypress/reports/*
cypress/screenshots/*
cypress/videos/*

cypress/cypress/results/*
cypress/cypress/reports/*
cypress/cypress/screenshots/*
cypress/cypress/videos/*

frontend/cypress/results/*
frontend/cypress/reports/*
frontend/cypress/screenshots/*
frontend/cypress/videos/*

reports/
frontend/reports/
13 changes: 9 additions & 4 deletions backend/openshift.deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ parameters:
- name: CPU_LIMIT
value: 200m
- name: MEMORY_REQUEST
value: 75Mi
value: 150Mi
- name: MEMORY_LIMIT
value: 75Mi
value: 150Mi
- name: BCREGISTRY_URI
description: Bc Registry API address
required: true
Expand Down Expand Up @@ -138,6 +138,11 @@ objects:
secretKeyRef:
name: ${NAME}-${ZONE}
key: bcregistry-account
- name: ADDRESS_COMPLETE_KEY
valueFrom:
secretKeyRef:
name: ${NAME}-${ZONE}
key: address-complete-key

ports:
- containerPort: 3000
Expand All @@ -151,12 +156,12 @@ objects:
memory: ${MEMORY_REQUEST}
readinessProbe:
successThreshold: 1
failureThreshold: 12
failureThreshold: 15
httpGet:
path: /health
port: 3000
scheme: HTTP
initialDelaySeconds: 180
initialDelaySeconds: 10
periodSeconds: 30
timeoutSeconds: 5
- apiVersion: v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,16 @@
import ca.bc.gov.app.dto.bcregistry.BcRegistryAddressDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryBusinessAdressesDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryBusinessDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryExceptionMessageDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryFacetResponseDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryFacetSearchResultEntryDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryFacetSearchResultsDto;
import ca.bc.gov.app.dto.bcregistry.BcRegistryIdentificationDto;
import ca.bc.gov.app.dto.bcregistry.ClientDetailsDto;
import ca.bc.gov.app.dto.ches.ChesMailErrorResponse;
import ca.bc.gov.app.dto.ches.ChesMailRequest;
import ca.bc.gov.app.dto.ches.ChesMailResponse;
import ca.bc.gov.app.dto.ches.ChesRequestDto;
import ca.bc.gov.app.dto.ches.CommonExposureJwtDto;
import ca.bc.gov.app.dto.client.AddressCompleteFindDto;
import ca.bc.gov.app.dto.client.AddressCompleteFindListDto;
Expand All @@ -32,8 +37,8 @@

/**
* <p><b>Global Service Configuration</b></p>
* This class is responsible for configuring basic beans to be used by the services.
* It creates and holds the external API webclients and the cors filter.
* This class is responsible for configuring basic beans to be used by the services. It creates and
* holds the external API webclients and the cors filter.
*/
@Configuration
@Slf4j
Expand All @@ -58,13 +63,19 @@
BcRegistryFacetSearchResultEntryDto.class,
BcRegistryFacetSearchResultsDto.class,
BcRegistryIdentificationDto.class,
BcRegistryExceptionMessageDto.class,
ClientDetailsDto.class,
CommonExposureJwtDto.class
CommonExposureJwtDto.class,
ChesRequestDto.class,
ChesMailRequest.class,
ChesMailResponse.class,
ChesMailErrorResponse.class
})
public class GlobalServiceConfiguration {

/**
* Returns a configured instance of WebClient to communicate with the CHES API
* based on the provided configuration.
* Returns a configured instance of WebClient to communicate with the CHES API based on the
* provided configuration.
*
* @param configuration the ForestClientConfiguration containing the CHES API base URI
* @return a WebClient instance configured with the CHES API base URI
Expand Down Expand Up @@ -108,8 +119,8 @@ public WebClient bcRegistryApi(ForestClientConfiguration configuration) {
}

/**
* Creates a WebClient instance for making HTTP requests to the Oracle Legacy API
* based on the provided {@link ForestClientConfiguration}.
* Creates a WebClient instance for making HTTP requests to the Oracle Legacy API based on the
* provided {@link ForestClientConfiguration}.
*
* @param configuration the configuration object for the Forest client
* @return a WebClient instance configured for the Oracle Legacy API
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ public Flux<ClientNameCodeDto> findPossibleAddresses(
.findPossibleAddresses(country, maxSuggestions, searchTerm);
}

@GetMapping("/address/{addressId}")
@GetMapping("/addresses/{addressId}")
@Operation(
summary = "Retrieve address",
responses = {
Expand Down
Loading

0 comments on commit 828ac25

Please sign in to comment.