-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cicd): Add UT to PR's via SonarCloud #121
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall,
few minor feedback to make sure tests run
we need lcov reporter for both frontend and backend
sample frontend config in QSOS, need similar here, https://github.com/bcgov/quickstart-openshift/blob/main/frontend/vitest.config.ts#L16
sample backend config which can be copy pasted here,
https://github.com/bcgov/quickstart-openshift/blob/main/backend/package.json#L101-L105
token: SONAR_TOKEN_FRONTEND | ||
steps: | ||
- uses: bcgov-nr/action-test-and-analyse@v1.2.1 | ||
with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need env variables for the tests to run, we can always pass all the frontend and backend env vars in the env:
, and then it will be picked by each job and they use based on their needs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit tests are running now without ading any env:
so I think it's okay without.
However, I am still having issues with SonarCloud getting the results of the tests, so still investigating.
…but leaving to verify next
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments