Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cicd): Add UT to PR's via SonarCloud #121
base: dev
Are you sure you want to change the base?
feat(cicd): Add UT to PR's via SonarCloud #121
Changes from 5 commits
dc249a6
2286de5
a428998
3db23a5
ae53cb7
bfd7e5b
9e9272f
29fe54b
c53495f
40a19d5
c2519fb
87c87a0
db17d12
02cc676
992a524
4660635
869673b
68f1043
7353791
1b19eb1
7ea51a8
ba65bc7
f8753ec
9b89d64
0d766f1
d25f88a
a9ea209
ab0dcba
40c7848
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may need env variables for the tests to run, we can always pass all the frontend and backend env vars in the
env:
, and then it will be picked by each job and they use based on their needsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit tests are running now without ading any
env:
so I think it's okay without.However, I am still having issues with SonarCloud getting the results of the tests, so still investigating.