Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added indexes on invoice ref table #1096

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Conversation

kialj876
Copy link
Collaborator

@kialj876 kialj876 commented Feb 8, 2023

Signed-off-by: Kial Jinnah kialjinnah@gmail.com

Issue #:
bcgov/entity#14376

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the sbc-pay license (Apache 2.0).

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@kialj876 kialj876 added the bug Something isn't working label Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #1096 (e78cd3d) into main (25f3363) will decrease coverage by 0.02%.
The diff coverage is 74.07%.

@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   91.53%   91.51%   -0.02%     
==========================================
  Files         153      162       +9     
  Lines        9894    10681     +787     
==========================================
+ Hits         9056     9775     +719     
- Misses        838      906      +68     
Flag Coverage Δ
eventlistenerqueue 81.81% <66.66%> (+0.18%) ⬆️
payadmin ∅ <ø> (?)
payapi 93.88% <85.00%> (+<0.01%) ⬆️
paymentjobs 78.95% <0.00%> (ø)
paymentreconciliationsqueue 91.31% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jobs/payment-jobs/tasks/routing_slip_task.py 89.52% <0.00%> (ø)
...ices/fas/routing_slip_status_transition_service.py 100.00% <ø> (ø)
pay-api/src/pay_api/services/payment_service.py 97.93% <ø> (ø)
...ces/events-listener/src/events_listener/version.py 0.00% <0.00%> (ø)
...ment-reconciliations/src/reconciliations/config.py 96.38% <ø> (ø)
...ons/src/reconciliations/payment_reconciliations.py 91.73% <0.00%> (ø)
...ment-reconciliations/src/reconciliations/worker.py 86.84% <0.00%> (ø)
pay-api/src/pay_api/services/cfs_service.py 69.93% <50.00%> (ø)
pay-api/src/pay_api/exceptions/__init__.py 100.00% <100.00%> (ø)
pay-api/src/pay_api/models/invoice_reference.py 100.00% <100.00%> (ø)
... and 16 more

Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
Signed-off-by: Kial Jinnah <kialjinnah@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@seeker25 seeker25 merged commit 152cf3d into bcgov:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants