ImportsChecker: fix lexicographic sort for groups #188
Conversation
Lexicographic imports sorting used in IDEs (Intellij, Eclipse) considers the entire import string. However, for groups, only the part preceding the group was passed into the comparison method. A follow-up to pull request scalastyle#234.
|
@mwz @SethTisue PTAL. Also, can you please fork https://github.com/scalastyle/scalastyle-maven-plugin here as well? we use maven and not sbt, so I'd like to update that one as well. |
|
LGTM, thanks for contributing @kitbellew. Regarding the maven plugin - it's not something that's in my plans, but feel free to link to the project on the website if you decide to fork it and maintain it yourself. |
what about you forking it under |
|
@mwz also, are you planning a release soon? |
apologies for the delay - just published 1.5.1 |
Lexicographic imports sorting used in IDEs (Intellij, Eclipse) considers the entire import string.
However, for groups, only the part preceding the group was passed into the comparison method.
A follow-up to pull request #234.