Skip to content

Conversation

kitbellew
Copy link

Lexicographic imports sorting used in IDEs (Intellij, Eclipse) considers
the entire import string.

However, for groups, only the part preceding the group was passed into
the comparison method, not taking into account the opening curly brace
and the symbol following it. Let's add them to get the right behaviour.

A follow-up to pull request #234.

Lexicographic imports sorting used in IDEs (Intellij, Eclipse) considers
the entire import string.

However, for groups, only the part preceding the group was passed into
the comparison method, not taking into account the opening curly brace
and the symbol following it. Let's add them to get the right behaviour.

A follow-up to pull request scalastyle#234.
@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #349 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #349   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          62     62           
  Lines        1495   1498    +3     
  Branches      146    146           
=====================================
- Misses       1495   1498    +3
Impacted Files Coverage Δ
...la/org/scalastyle/scalariform/ImportsChecker.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec14399...6bfcd59. Read the comment docs.

@kitbellew
Copy link
Author

@matthewfarwell can you please take another look? my previous commit, #234 2 years ago, turned out to be incomplete and leads to conflicts with IDEs when import rename is used.

@dvwilliamson
Copy link

dvwilliamson commented May 19, 2020

@SethTisue It looks like you may have more recently looked at this repo. It looks like a good PR for a good repo, but no one's merged it in for a while. Trying to give my upvote for what its worth.

@SethTisue
Copy link
Contributor

@kitbellew
Copy link
Author

@dvwilliamson the action's over at @mwz's https://github.com/beautiful-scala/scalastyle

thanks, closing this, created beautiful-scala#188

@kitbellew kitbellew closed this Jul 3, 2021
@kitbellew kitbellew deleted the leximport2 branch July 3, 2021 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants