[doctrineGH-3837] Trigger deprecation for QueryBuilder::select/addSel…

…ect/groupBy/addGroupBy with array argument.
beberlei · Mar 11, 2021 · 9981c03 · 9981c03
1 parent 5d20e3c
commit 9981c03
Showing 1 changed file with 37 additions and 0 deletions.
diff --git a/lib/Doctrine/DBAL/Query/QueryBuilder.php b/lib/Doctrine/DBAL/Query/QueryBuilder.php
@@ -9,6 +9,7 @@
 use Doctrine\DBAL\Query\Expression\CompositeExpression;
 use Doctrine\DBAL\Query\Expression\ExpressionBuilder;
 use Doctrine\DBAL\Types\Type;
+use Doctrine\Deprecations\Deprecation;
 
 use function array_filter;
 use function array_key_exists;
@@ -483,6 +484,15 @@ public function select($select = null/*, string ...$selects*/)
  return $this;
  }
 
+ if (is_array($select)) {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/issues/3837',
+ 'Passing an array for the first argument to QueryBuilder::select is deprecated, ' .
+ 'pass each value as an individual variadic argument instead.'
+ );
+ }
+
  $selects = is_array($select) ? $select : func_get_args();
 
  return $this->add('select', $selects);
@@ -533,6 +543,15 @@ public function addSelect($select = null/*, string ...$selects*/)
  return $this;
  }
 
+ if (is_array($select)) {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/issues/3837',
+ 'Passing an array for the first argument to QueryBuilder::addSelect is deprecated, ' .
+ 'pass each value as an individual variadic argument instead.'
+ );
+ }
+
  $selects = is_array($select) ? $select : func_get_args();
 
  return $this->add('select', $selects, true);
@@ -911,6 +930,15 @@ public function groupBy($groupBy/*, string ...$groupBys*/)
  return $this;
  }
 
+ if (is_array($groupBy)) {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/issues/3837',
+ 'Passing an array for the first argument to QueryBuilder::groupBy is deprecated, ' .
+ 'pass each value as an individual variadic argument instead.'
+ );
+ }
+
  $groupBy = is_array($groupBy) ? $groupBy : func_get_args();
 
  return $this->add('groupBy', $groupBy, false);
@@ -940,6 +968,15 @@ public function addGroupBy($groupBy/*, string ...$groupBys*/)
  return $this;
  }
 
+ if (is_array($groupBy)) {
+ Deprecation::trigger(
+ 'doctrine/dbal',
+ 'https://github.com/doctrine/dbal/issues/3837',
+ 'Passing an array for the first argument to QueryBuilder::addGroupBy is deprecated, ' .
+ 'pass each value as an individual variadic argument instead.'
+ );
+ }
+
  $groupBy = is_array($groupBy) ? $groupBy : func_get_args();
 
  return $this->add('groupBy', $groupBy, true);