Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the usage of arrays in QueryBuilder methods #3837

Closed
morozov opened this issue Jan 21, 2020 · 5 comments
Closed

Deprecate the usage of arrays in QueryBuilder methods #3837

morozov opened this issue Jan 21, 2020 · 5 comments
Assignees
Milestone

Comments

@morozov
Copy link
Member

morozov commented Jan 21, 2020

The usage of array arguments in QueryBuilder::select(), ::addSelect(), ::groupBy() and ::addGroupBy() methods needs to be deprecated.

Their support was removed in #3831.

Before:

$qb->select(['id', 'email', 'name']);
$qb->addSelect($columns);

After:

$qb->select('id', 'email', 'name');
$qb->addSelect(...$columns);
@morozov
Copy link
Member Author

morozov commented Jan 28, 2020

@BenMorel do you want to address this one as well before the up-merge? I'll do the merge later today regardless of the status of this issue.

@BenMorel
Copy link
Contributor

Do you just want to mark them as deprecated? Or raise a deprecation notice?

@morozov
Copy link
Member Author

morozov commented Jan 28, 2020

Just document the usage of array arguments as deprecated in the method descriptions. Not using the @deprecated annotation since it would deprecate the methods, not using trigger_error().

@morozov
Copy link
Member Author

morozov commented Jan 28, 2020

Fixed by #3853.

@morozov morozov closed this as completed Jan 28, 2020
@morozov morozov self-assigned this Jan 28, 2020
beberlei added a commit to beberlei/dbal that referenced this issue Mar 7, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 7, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 11, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 22, 2021
beberlei added a commit to beberlei/dbal that referenced this issue Mar 27, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants