Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Some graal modules are not visible in runtime and driver modules and break Truffle interoperability #367

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

stratika
Copy link
Collaborator

@stratika stratika commented Mar 29, 2024

Description

Problem:
I tried to build the latest polyglot docker images with the latest TornadoVM version in develop and I got some problems related to graal modules that cannot be read from some tornado modules (tornado-runtime, tornado-drivers/opencl, tornado-drivers/ptx).

For instance:

tornado --printKernel --truffle python tornado-assembly/src/examples/polyglotTruffle/mxmWithTornadoVM.py

class uk.ac.manchester.tornado.runtime.TornadoCoreRuntime (in module tornado.runtime) cannot access class org.graalvm.collections.EconomicMap (in module org.graalvm.collections) because module tornado.runtime does not read module org.graalvm.collections
Traceback (most recent call last):
class uk.ac.manchester.tornado.runtime.TornadoCoreRuntime (in module tornado.runtime) cannot access class org.graalvm.collections.EconomicMap (in module org.graalvm.collections) because module tornado.runtime does not read module org.graalvm.collections
Traceback (most recent call last):
class uk.ac.manchester.tornado.runtime.TornadoCoreRuntime (in module tornado.runtime) cannot access class org.graalvm.collections.EconomicMap (in module org.graalvm.collections) because module tornado.runtime does not read module org.graalvm.collections

For the record, the SPIR-V backend is working. It did not throw this compatibility issue.

Solution: To address the problem this PR adds the modules as required in the relevant tornado modules.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

To test the new patch, you must build GraalPython or TruffleRuby or GraalJS as described here. Once you have graalpython built, you can test it by using:

export GRAALPY_HOME=<your-directory>/graalpy-dev/graal/sdk/mxbuild/linux-amd64/GRAALVM_03DCD25EA1_JAVA21/graalvm-03dcd25ea1-java21-23.1.0-dev

make graal-jdk-21 BACKEND=opencl
tornado --printKernel --truffle python tornado-assembly/src/examples/polyglotTruffle/mxmWithTornadoVM.py

make graal-jdk-21 BACKEND=ptx
tornado --printKernel --truffle python tornado-assembly/src/examples/polyglotTruffle/mxmWithTornadoVM.py

make graal-jdk-21 BACKEND=spirv
tornado --printKernel --truffle python tornado-assembly/src/examples/polyglotTruffle/mxmWithTornadoVM.py

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2024

CLA assistant check
All committers have signed the CLA.

@stratika stratika self-assigned this Mar 29, 2024
@stratika stratika added the bug Something isn't working label Mar 29, 2024
Copy link
Member

@mikepapadim mikepapadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Member

@jjfumero jjfumero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratika stratika merged commit 960b2fd into beehive-lab:develop Apr 3, 2024
2 checks passed
@stratika stratika deleted the fix/truffle/modules branch April 3, 2024 09:30
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request Apr 30, 2024
Improvements
~~~~~~~~~~~~~~~~~~

- [beehive-lab#369](beehive-lab#369): Introduction of Tensor types in TornadoVM API and interoperability with ONNX Runtime.
- [beehive-lab#370](beehive-lab#370): Array concatenation operation for TornadoVM native arrays.
- [beehive-lab#371](beehive-lab#371): TornadoVM installer script ported for Windows 10/11.
- [beehive-lab#372](beehive-lab#372): Add support for ``HalfFloat`` (``Float16``) in vector types.
- [beehive-lab#374](beehive-lab#374): Support for TornadoVM array concatenations from the constructor-level.
- [beehive-lab#375](beehive-lab#375): Support for TornadoVM native arrays using slices from the Panama API.
- [beehive-lab#376](beehive-lab#376): Support for lazy copy-outs in the batch processing mode.
- [beehive-lab#377](beehive-lab#377): Expand the TornadoVM profiler with power metrics for NVIDIA GPUs (OpenCL and PTX backends).
- [beehive-lab#384](beehive-lab#384): Auto-closable Execution Plans for automatic memory management.

Compatibility
~~~~~~~~~~~~~~~~~~

- [beehive-lab#386](beehive-lab#386): OpenJDK 17 support removed.
- [beehive-lab#390](beehive-lab#390): SapMachine OpenJDK 21 supported.
- [beehive-lab#395](beehive-lab#395): OpenJDK 22 and GraalVM 22.0.1 supported.
- TornadoVM tested with Apple M3 chips.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- [beehive-lab#367](beehive-lab#367): Fix for Graal/Truffle languages in which some Java modules were not visible.
- [beehive-lab#373](beehive-lab#373): Fix for data copies of the ``HalfFloat`` types for all backends.
- [beehive-lab#378](beehive-lab#378): Fix free memory markers when running multi-thread execution plans.
- [beehive-lab#379](beehive-lab#379): Refactoring package of vector api unit-tests.
- [beehive-lab#380](beehive-lab#380): Fix event list sizes to accommodate profiling of large applications.
- [beehive-lab#385](beehive-lab#385): Fix code check style.
- [beehive-lab#387](beehive-lab#387): Fix TornadoVM internal events in OpenCL, SPIR-V and PTX for running multi-threaded execution plans.
- [beehive-lab#388](beehive-lab#388): Fix of expected and actual values of tests.
- [beehive-lab#392](beehive-lab#392): Fix installer for using existing JDKs.
- [beehive-lab#389](beehive-lab#389): Fix ``DataObjectState`` for multi-thread execution plans.
- [beehive-lab#396](beehive-lab#396): Fix JNI code for the CUDA NVML library access with OpenCL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

4 participants