Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Windows installer improved #411

Merged
merged 6 commits into from
May 10, 2024

Conversation

jjfumero
Copy link
Member

@jjfumero jjfumero commented May 9, 2024

Description

Windows installer improved. With this patch, there is no need to invoke Python explicitly on Windows.

Problem description

n/a.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

From the terminal within IntelliJ

> .\bin\windowsMicrosoftStudioTools2022.cmd
> pip install pyinstaller  
> python bin\tornadovm-installer --jdk jdk21 --backend=opencl 
> setvars.cmd

Testing:

> tornado-test -V 
## Run NBODY
> tornado -m tornado.examples/uk.ac.manchester.tornado.examples.compute.NBody

@stratika
Copy link
Collaborator

stratika commented May 9, 2024

I had the problem of pyinstaller being an unrecognized command from the terminal that was opened from IntelliJ. I got this output:

creating tornado binary ....
'pyinstaller' is not recognized as an internal or external command,
operable program or batch file.
ok
creating tornado-test binary ....
'pyinstaller' is not recognized as an internal or external command,
operable program or batch file.
ok
creating tornado-benchmarks.py binary ....
'pyinstaller' is not recognized as an internal or external command,
operable program or batch file.

To resolve that problem I had to go to the "Edit the system environment variables" menu, click the "Environment Variables", and add in the PATH variable this path: "C:\Users\nasos\AppData\Local\Programs\Python\Python312\Scripts".

I had first installed pyinstaller using pip3 from a terminal:

pip install pyinstaller

Once doing those steps, I had to restart IntelliJ. Did you do something different? This should be documented, because someone who does not have pyinstaller in the system, will get the same error.

Copy link
Collaborator

@stratika stratika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commands are working, the only thing is that pyinstaller is a new dependency that should be installed. I suggest to include this information in the following PR that will improve the documentation for Windows installation.

@jjfumero jjfumero merged commit 6f0f055 into beehive-lab:develop May 10, 2024
2 checks passed
@jjfumero jjfumero deleted the enhance/windows/installer branch May 10, 2024 06:29
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request May 28, 2024
Improvements
~~~~~~~~~~~~~~~~~~

- beehive-lab#402 <beehive-lab#402>: Support for TornadoNativeArrays from FFI buffers.
- beehive-lab#403 <beehive-lab#403>: Clean-up and refactoring for the code analysis of the loop-interchange.
- beehive-lab#405 <beehive-lab#405>: Disable Loop-Interchange for CPU offloading..
- beehive-lab#407 <beehive-lab#407>: Debugging OpenCL Kernels builds improved.
- beehive-lab#410 <beehive-lab#410>: CPU block scheduler disabled by default and option to switch between different thread-schedulers added.
- beehive-lab#418 <beehive-lab#418>: TornadoOptions and TornadoLogger improved.
- beehive-lab#423 <beehive-lab#423>: MxM using ns instead of ms to report performance.
- beehive-lab#425 <beehive-lab#425>: Vector types for ``Float<Width>`` and ``Int<Width>`` supported.
- beehive-lab#429 <beehive-lab#429>: Documentation of the installation process updated and improved.
- beehive-lab#432 <beehive-lab#432>: Support for SPIR-V code generation and dispatcher using the TornadoVM OpenCL runtime.

Compatibility
~~~~~~~~~~~~~~~~~~

- beehive-lab#409 <beehive-lab#409>: Guidelines to build the documentation.
- beehive-lab#411 <beehive-lab#411>: Windows installer improved.
- beehive-lab#412 <beehive-lab#412>: Python installer improved to check download all Python dependencies before the main installer.
- beehive-lab#413 <beehive-lab#413>: Improved documentation for installing all configurations of backends and OS.
- beehive-lab#424 <beehive-lab#424>: Use Generic GPU Scheduler for some older NVIDIA Drivers for the OpenCL runtime.
- beehive-lab#430 <beehive-lab#430>: Improved the installer by checking  that the TornadoVM environment is loaded upfront.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- beehive-lab#400 <beehive-lab#400>: Fix batch computation when the global thread indexes are used to compute the outputs.
- beehive-lab#414 <beehive-lab#414>: Recover Test-Field unit-tests using Panama types.
- beehive-lab#415 <beehive-lab#415>: Check style errors fixed.
- beehive-lab#416 <beehive-lab#416>: FPGA execution with multiple tasks in a task-graph fixed.
- beehive-lab#417 <beehive-lab#417>: Lazy-copy out fixed for Java fields.
- beehive-lab#420 <beehive-lab#420>: Fix Mandelbrot example.
- beehive-lab#421 <beehive-lab#421>: OpenCL 2D thread-scheduler fixed for NVIDIA GPUs.
- beehive-lab#422 <beehive-lab#422>: Compilation for NVIDIA Jetson Nano fixed.
- beehive-lab#426 <beehive-lab#426>: Fix Logger for all backends.
- beehive-lab#428 <beehive-lab#428>: Math cos/sin operations supported for vector types.
- beehive-lab#431 <beehive-lab#431>: Jenkins files fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants