Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Checkstyle errors fixed #415

Merged
merged 1 commit into from
May 10, 2024
Merged

[chore] Checkstyle errors fixed #415

merged 1 commit into from
May 10, 2024

Conversation

stratika
Copy link
Collaborator

@stratika stratika commented May 10, 2024 •
edited
Loading

Description

There were some issues regarding the checkstyle of code base.

make checkstyle
...
[INFO] There are 3 errors reported by Checkstyle 9.3 with tornado-assembly/src/etc/checkstyle.xml ruleset.
[ERROR] src/main/java/uk/ac/manchester/tornado/api/types/arrays/IntArray.java:[24,8] (imports) UnusedImports: Unused import - java.lang.foreign.ValueLayout.
[ERROR] src/main/java/uk/ac/manchester/tornado/api/types/arrays/IntArray.java:[139] (regexp) RegexpSinglelineJava: Illegal trailing whitespace(s) at the end of the line.
[ERROR] src/main/java/uk/ac/manchester/tornado/api/types/arrays/ByteArray.java:[26,8] (imports) UnusedImports: Unused import - java.nio.FloatBuffer.

This PR fixes them.

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

make checkstyle

@stratika stratika requested a review from jjfumero May 10, 2024 11:32
@stratika stratika self-assigned this May 10, 2024
@stratika stratika requested a review from mairooni May 10, 2024 11:32
@mairooni mairooni mentioned this pull request May 10, 2024
Merged
8 tasks
@jjfumero jjfumero merged commit 801038c into beehive-lab:develop May 10, 2024
2 checks passed
@stratika stratika deleted the fix/checkstyle branch May 13, 2024 14:36
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request May 28, 2024
@jjfumero
[release] TornadoVM 1.0.5
ed7b8de 
Improvements
~~~~~~~~~~~~~~~~~~

- beehive-lab#402 <beehive-lab#402>: Support for TornadoNativeArrays from FFI buffers.
- beehive-lab#403 <beehive-lab#403>: Clean-up and refactoring for the code analysis of the loop-interchange.
- beehive-lab#405 <beehive-lab#405>: Disable Loop-Interchange for CPU offloading..
- beehive-lab#407 <beehive-lab#407>: Debugging OpenCL Kernels builds improved.
- beehive-lab#410 <beehive-lab#410>: CPU block scheduler disabled by default and option to switch between different thread-schedulers added.
- beehive-lab#418 <beehive-lab#418>: TornadoOptions and TornadoLogger improved.
- beehive-lab#423 <beehive-lab#423>: MxM using ns instead of ms to report performance.
- beehive-lab#425 <beehive-lab#425>: Vector types for ``Float<Width>`` and ``Int<Width>`` supported.
- beehive-lab#429 <beehive-lab#429>: Documentation of the installation process updated and improved.
- beehive-lab#432 <beehive-lab#432>: Support for SPIR-V code generation and dispatcher using the TornadoVM OpenCL runtime.

Compatibility
~~~~~~~~~~~~~~~~~~

- beehive-lab#409 <beehive-lab#409>: Guidelines to build the documentation.
- beehive-lab#411 <beehive-lab#411>: Windows installer improved.
- beehive-lab#412 <beehive-lab#412>: Python installer improved to check download all Python dependencies before the main installer.
- beehive-lab#413 <beehive-lab#413>: Improved documentation for installing all configurations of backends and OS.
- beehive-lab#424 <beehive-lab#424>: Use Generic GPU Scheduler for some older NVIDIA Drivers for the OpenCL runtime.
- beehive-lab#430 <beehive-lab#430>: Improved the installer by checking  that the TornadoVM environment is loaded upfront.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- beehive-lab#400 <beehive-lab#400>: Fix batch computation when the global thread indexes are used to compute the outputs.
- beehive-lab#414 <beehive-lab#414>: Recover Test-Field unit-tests using Panama types.
- beehive-lab#415 <beehive-lab#415>: Check style errors fixed.
- beehive-lab#416 <beehive-lab#416>: FPGA execution with multiple tasks in a task-graph fixed.
- beehive-lab#417 <beehive-lab#417>: Lazy-copy out fixed for Java fields.
- beehive-lab#420 <beehive-lab#420>: Fix Mandelbrot example.
- beehive-lab#421 <beehive-lab#421>: OpenCL 2D thread-scheduler fixed for NVIDIA GPUs.
- beehive-lab#422 <beehive-lab#422>: Compilation for NVIDIA Jetson Nano fixed.
- beehive-lab#426 <beehive-lab#426>: Fix Logger for all backends.
- beehive-lab#428 <beehive-lab#428>: Math cos/sin operations supported for vector types.
- beehive-lab#431 <beehive-lab#431>: Jenkins files fixed.
@jjfumero jjfumero mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjfumero jjfumero jjfumero approved these changes

@mairooni mairooni mairooni approved these changes

Assignees

@stratika stratika

Labels
code-style
Projects
TornadoVM 1.X (Public)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stratika @jjfumero @mairooni