Support for JDK 22.0.2 and migrate to Graal compiler 24.0.2 #465

mikepapadim · 2024-06-27T07:02:44Z

This PR is in working state for TornadoVM running with JDK22 and Graal 24.0.1.

How to test:

make jdk22 BACKEND=opencl
make tests

make jdk22 BACKEND=ptx
make tests

make jdk22 BACKEND=spirv
make tests

Excpected pass-rate:

…jdk22_2nd_iteration

…Plugins

…hase

…gins

andrii0lomakin · 2024-07-09T11:16:25Z

@mikepapadim, will JDK 21 still be supported? Many companies will deny to use non-LTS versions.

mikepapadim · 2024-07-09T11:38:42Z

@mikepapadim, will JDK 21 still be supported? Many companies will deny to use non-LTS versions.

We dont plan to merge this at least until the next LTS-release (JDK25, Sept 2025).
We are going to keep into a seperate branch in case users on JDK22+ want to use TornadoVM.

andrii0lomakin · 2024-07-09T11:43:52Z

@mikepapadim Got it, but do you plan to merge the new proxy implementation for MemorySegment?

mikepapadim · 2024-07-25T08:57:28Z

This now ready:

Pass-rate:

SPIR-V:

==================================================
              Unit tests report 
==================================================

{'[PASS]': 572, '[FAILED]': 5, '[UNSUPPORTED]': 141}
Coverage [PASS/(PASS+FAIL)]: 99.13%
Coverage [PASS/(PASS+FAIL+UNSUPPORTED)]: 79.67%

==================================================

PTX:

==================================================
              Unit tests report 
==================================================

{'[PASS]': 658, '[FAILED]': 4, '[UNSUPPORTED]': 56}
Coverage [PASS/(PASS+FAIL)]: 99.4%
Coverage [PASS/(PASS+FAIL+UNSUPPORTED)]: 91.64%

==================================================

OpenCL:

==================================================
              Unit tests report 
==================================================

{'[PASS]': 668, '[FAILED]': 5, '[UNSUPPORTED]': 45}
Coverage [PASS/(PASS+FAIL)]: 99.26%
Coverage [PASS/(PASS+FAIL+UNSUPPORTED)]: 93.04%

==================================================

jjfumero · 2024-07-25T09:27:54Z

Awesome!

@mairooni , @stratika and myself, let's initiate final testing.

Note, this branch is not going to be merge due to changes in GraalVM - JDK. The idea is to keep this branch alive and aligned with master until JDK 25. Then this branch will be pushed into master.

…nadoVM into feat/jdk22_2nd_iteration

jjfumero · 2024-07-29T13:54:58Z

...ado-drivers/opencl/src/main/java/uk/ac/manchester/tornado/drivers/opencl/graal/OCLStamp.java

-        if (stamp instanceof OCLStamp && ((OCLStamp) stamp).oclKind == oclKind) {
-            return true;
-        }
+            if (stamp instanceof OCLStamp) {


Shouldn't we have also this for the PTX backend?

we do have it: faad244

…nadoVM into feat/jdk22_2nd_iteration

andrii0lomakin · 2024-07-31T12:14:41Z

BTW OpenJDK 23 already has GraalJIT inside of IT https://download.java.net/java/early_access/jdk23/docs/specs/man/java.html#enabling-the-graal-jit-compiler, so there will be no need to provide separate jars.

stratika · 2024-07-31T16:51:26Z

Here is a summary of the tests I have tried. I think it looks in an advanced state the branch, I have spotted three issues.

The polyglot tests are working.
I added the links for the JDK 22 vendors and tested the tornadovm-installer script in macOS and linux.
The pass-rate of the unit-tests is the same as in develop (JDK 21) in my system. Only one of the whitelisted tests (mxm2DKernelContext02()) is failing in the codegen, while in develop it is generating kernels. I added an issue: Code gen issue in the JDK 22 branch for matrix multiplication unit-test that uses the Kernel API #518
There seems to be an issue with the addresses in the FPGA kernels: FPGA result is not correct in JDK 22 branch, due to casting of the address type #517
The TornadoVM-Ray-Tracer is tested for OpenCL. However, the SPIR-V backend has an issue. [bug] Issue in TornadoVM-Ray-Tracer with SPIR-V in the JDK 22 branch #520

stratika · 2024-08-01T09:04:04Z

Here is a summary of the tests I have tried. I think it looks in an advanced state the branch, I have spotted three issues.

The polyglot tests are working.

I added the links for the JDK 22 vendors and tested the tornadovm-installer script in macOS and linux.

The pass-rate of the unit-tests is the same as in develop (JDK 21) in my system. Only one of the whitelisted tests (mxm2DKernelContext02()) is failing in the codegen, while in develop it is generating kernels. I added an issue: Code gen issue in the JDK 22 branch for matrix multiplication unit-test that uses the Kernel API #518

There seems to be an issue with the addresses in the FPGA kernels: FPGA result is not correct in JDK 22 branch, due to casting of the address type #517

The TornadoVM-Ray-Tracer is tested for OpenCL. However, the SPIR-V backend has an issue. [bug] Issue in TornadoVM-Ray-Tracer with SPIR-V in the JDK 22 branch #520

I tested the branch for OpenCL and PTX on Windows 11. I did a minor update in the Makefile.mak file to be synced with the Makefile.

jjfumero · 2024-08-29T10:08:33Z

Latest version available in: https://github.com/beehive-lab/TornadoVM/tree/jdk22-graal-24.0.2

Improvements ~~~~~~~~~~~~~~~~~~ - beehive-lab#468: Cleanup Abstract Metadata Class. - beehive-lab#473: Add maven plugin to build TornadoVM source for the releases. - beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`. - beehive-lab#482: Help messages improve when an out-of-memory exception is raised. - beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class. - beehive-lab#487: Prebuilt API simplified. - beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments. - beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development. - beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay. - beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks. - beehive-lab#538: `README` file updated. - beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero). - beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer. Compatibility ~~~~~~~~~~~~~~~~~~ - beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2. - beehive-lab#486: Temurin for Windows added in the list of supported JDKs. - beehive-lab#525: Revert usage of String Templates in preparation for JDK 23. - beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay). - beehive-lab#513: LevelZero JNI Library updated to v0.1.4. Bug Fixes ~~~~~~~~~~~~~~~~~~ - beehive-lab#470: README documentation fixed. - beehive-lab#478: Fix the test names that are present in the white list. - beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed. - beehive-lab#493: Tests Whitelist for PTX backend fixed. - beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions. - beehive-lab#514: Installer script fixed. - beehive-lab#540: Fix issue with clean-up execution IDs function. - beehive-lab#541: Fix Data Accessors for the prebuilt API. - beehive-lab#543: Fix checkstyle condition and FP16 error message improved.

Improvements ~~~~~~~~~~~~~~~~~~ - beehive-lab#468: Cleanup Abstract Metadata Class. - beehive-lab#473: Add maven plugin to build TornadoVM source for the releases. - beehive-lab#474: Refactor `<X>TornadoDevice` to place common methods in the `TornadoXPUInterface`. - beehive-lab#482: Help messages improved when an out-of-memory exception is raised. - beehive-lab#484: Double-type for the trigonometric functions added in the `TornadoMath` class. - beehive-lab#487: Prebuilt API simplified. - beehive-lab#494: Add test to trigger unsupported features related to direct use of Memory Segments. - beehive-lab#509: Add a quick pass configuration to skip the heavy tests during active development. - beehive-lab#532: Improve thread scheduler to support RISC-V Accelerators from Codeplay. - beehive-lab#533: Support for scalar values to be passed via lambda expressions as tasks. - beehive-lab#538: `README` file updated. - beehive-lab#539: Refactor core classes and add new API methods to pass compilation flags to the low-level driver compilers (OpenCL, PTX and Level Zero). - beehive-lab#542: Tagged LevelZero JNI and Beehive Toolkit dependencies added in the build and installer. Compatibility ~~~~~~~~~~~~~~~~~~ - beehive-lab#465: Support for JDK 22 and GraalVM 24.0.2. - beehive-lab#486: Temurin for Windows added in the list of supported JDKs. - beehive-lab#525: Revert usage of String Templates in preparation for JDK 23. - beehive-lab#527: SPIR-V version parameter added. TornadoVM may run previous SPIR-V versions (e.g., ComputeAorta from Codeplay). - beehive-lab#513: LevelZero JNI Library updated to v0.1.4. Bug Fixes ~~~~~~~~~~~~~~~~~~ - beehive-lab#470: README documentation fixed. - beehive-lab#478: Fix the test names that are present in the white list. - beehive-lab#488: FP64 Kind for radian operations and the PTX backend fixed. - beehive-lab#493: Tests Whitelist for PTX backend fixed. - beehive-lab#502: Fix barrier type in the documentation regarding programmability of reductions. - beehive-lab#514: Installer script fixed. - beehive-lab#540: Fix issue with clean-up execution IDs function. - beehive-lab#541: Fix Data Accessors for the prebuilt API. - beehive-lab#543: Fix checkstyle condition and FP16 error message improved. minor change

mikepapadim added 10 commits May 14, 2024 13:34

Update GraalVM for JDK22 support

38388c2

First working version

c67a266

Fix pom file for jdk22

e1a677a

wip

cb1be06

wip

117d0a0

Add TornadoMemorySegment and update methods in FloatArray

e957e4f

Enhance Tornado API with expanded memory segment operations

4f0afeb

Merge branch 'develop' of github.com:beehive-lab/TornadoVM into feat/…

f98f686

…jdk22_2nd_iteration

Update import statements and rearrange methods

dc142ce

Fix array initialization and remove debug output

fa04b2b

mikepapadim requested review from jjfumero, mairooni and stratika June 27, 2024 07:02

mikepapadim added 14 commits July 2, 2024 11:46

Swap 'setAtIndex' and 'getAtIndex' functionalities in OCLGraphBuilder…

d31dd65

…Plugins

Update OpenCL graph building and vector handling

5d1019d

Refactor Tensor type classes for code consistency

d7881fb

Fix short array index in initialization

98f79bb

Add initial value for atomic integers in Tornado

285a6f6

Refactor and optimize OCLGraphBuilder and TornadoAtomicsParameters

e2af570

Refactor atomic parameter initialization in TornadoAtomicsParametersP…

ea98443

…hase

Refactor and clean up imports in PTX compiler code

7f92f13

Refactor code for improved readability and remove redundancy

d572a4d

Refactor code and update exports in ptx drivers

9c2665f

Refactor TornadoFixedArrayCopyPhase class

f7596ed

Reorder code and fix HalfFloatPlaceholder receiver in OCLHalfFloatPlu…

8ef58b2

…gins

Update method used in testFloat task

1d87e70

Remove unused code in ExceptionSuppression

d0314f9

mikepapadim changed the title ~~Migrate TornadoVM to JDK22 and update Graal compiler to 24.0.1~~ Support for JDK22 and migrate to Graal compiler 24.0.1 Jul 25, 2024

jjfumero assigned mikepapadim Jul 25, 2024

jjfumero added the graal-update Update the Graal JIT compiler label Jul 25, 2024

Update Graal JAR version to 24.0.2

0c28c94

mikepapadim changed the title ~~Support for JDK22 and migrate to Graal compiler 24.0.1~~ Support for JDK 22.0.2 and migrate to Graal compiler 24.0.2 Jul 27, 2024

mikepapadim and others added 5 commits July 27, 2024 13:29

Merge branch 'develop' into feat/jdk22_2nd_iteration

84ddec8

Merge remote-tracking branch 'origin' into feat/jdk22_2nd_iteration

b7d672a

Remove extra --ea flags from test commands

be1fdfa

Merge branch 'feat/jdk22_2nd_iteration' of github.com:mikepapadim/Tor…

67b7604

…nadoVM into feat/jdk22_2nd_iteration

Update isCompatible to handle ObjectStamp in OCLStamp

2ffe8ac

jjfumero reviewed Jul 29, 2024

View reviewed changes

mikepapadim and others added 8 commits July 29, 2024 15:46

Simplify SPIRVStamp compatibility check

cdd1784

[feat] Update graalvm version in pom file

f500922

Refactor method to use fromJavaKind over fromResolvedJavaType

6c58f20

Merge branch 'feat/jdk22_2nd_iteration' of github.com:mikepapadim/Tor…

e5efad2

…nadoVM into feat/jdk22_2nd_iteration

Update installer_config.py for JDK 22

c0f6e63

Update tornadovm-installer

e63d1bd

Update installer_config.py

a6c083b

Update installer_config.py

dec5a87

stratika added 2 commits August 1, 2024 11:02

Update Makefile.mak

ac27953

Update Makefile.mak with new rules same as in Makefile

e6b5dca

jjfumero mentioned this pull request Aug 30, 2024

[release] TornadoVM 1.0.7 #546

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for JDK 22.0.2 and migrate to Graal compiler 24.0.2 #465

Support for JDK 22.0.2 and migrate to Graal compiler 24.0.2 #465

mikepapadim commented Jun 27, 2024 •

edited

Loading

andrii0lomakin commented Jul 9, 2024

mikepapadim commented Jul 9, 2024

andrii0lomakin commented Jul 9, 2024

mikepapadim commented Jul 25, 2024 •

edited

Loading

jjfumero commented Jul 25, 2024

jjfumero Jul 29, 2024

mikepapadim Jul 29, 2024

andrii0lomakin commented Jul 31, 2024

stratika commented Jul 31, 2024

stratika commented Aug 1, 2024

jjfumero commented Aug 29, 2024

Support for JDK 22.0.2 and migrate to Graal compiler 24.0.2 #465

Are you sure you want to change the base?

Support for JDK 22.0.2 and migrate to Graal compiler 24.0.2 #465

Conversation

mikepapadim commented Jun 27, 2024 • edited Loading

andrii0lomakin commented Jul 9, 2024

mikepapadim commented Jul 9, 2024

andrii0lomakin commented Jul 9, 2024

mikepapadim commented Jul 25, 2024 • edited Loading

jjfumero commented Jul 25, 2024

jjfumero Jul 29, 2024

Choose a reason for hiding this comment

mikepapadim Jul 29, 2024

Choose a reason for hiding this comment

andrii0lomakin commented Jul 31, 2024

stratika commented Jul 31, 2024

stratika commented Aug 1, 2024

jjfumero commented Aug 29, 2024

mikepapadim commented Jun 27, 2024 •

edited

Loading

mikepapadim commented Jul 25, 2024 •

edited

Loading